Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 593133002: Refactor: remove a Chromevox abstract class. (Closed)

Created:
6 years, 3 months ago by Peter Lundblad
Modified:
6 years, 3 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nkostylev+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkcr
Project:
chromium
Visibility:
Public.

Description

Refactor: remove a Chromevox abstract class. Removes the superflous cvox.AbstractMsgs class and moves what was rpeviously ChromeMsgs out of host. BUG=341953 R=dtseng@chromium.org Committed: https://crrev.com/773c53fcf84624a0d1ff4d50f6de5368c37b99b5 Cr-Commit-Position: refs/heads/master@{#296367}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -271 lines) Patch
M chrome/browser/resources/chromeos/chromevox/chromevox/background/background.js View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/background/loader.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/init_globals.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/loader.js View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/resources/chromeos/chromevox/chromevox/messages/msgs.js View 5 chunks +11 lines, -21 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/chromevox.js View 2 chunks +3 lines, -3 lines 0 comments Download
D chrome/browser/resources/chromeos/chromevox/host/chrome/msgs.js View 1 chunk +0 lines, -94 lines 0 comments Download
D chrome/browser/resources/chromeos/chromevox/host/interface/abstract_msgs.js View 1 chunk +0 lines, -48 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/host/interface/host_factory.js View 3 chunks +2 lines, -18 lines 0 comments Download
D chrome/browser/resources/chromeos/chromevox/host/testing/msgs.js View 1 chunk +0 lines, -77 lines 0 comments Download
A chrome/browser/resources/chromeos/chromevox/testing/test_msgs.js View 1 chunk +54 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/walkers/table_shifter.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/walkers/table_walker.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Peter Lundblad
6 years, 3 months ago (2014-09-23 14:10:18 UTC) #1
David Tseng
lgtm
6 years, 3 months ago (2014-09-23 17:27:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/593133002/1
6 years, 3 months ago (2014-09-24 07:39:36 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 671ee1be3591ca23551d5fac479031358ce9a72c
6 years, 3 months ago (2014-09-24 08:12:39 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 08:13:17 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/773c53fcf84624a0d1ff4d50f6de5368c37b99b5
Cr-Commit-Position: refs/heads/master@{#296367}

Powered by Google App Engine
This is Rietveld 408576698