chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js - Issue 593133002: Refactor: remove a Chromevox abstract class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js

Issue 593133002: Refactor: remove a Chromevox abstract class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/chromevox/background/loader.js ('k') | chrome/browser/resources/chromeos/chromevox/chromevox/injected/init_globals.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js

diff --git a/chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js b/chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js

index 8ecc90ed71fbc3b902750a8ff69e7af827eb8e9d..48684376a60a1760693e23dcee1d28ed119defbc 100644

--- a/chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js

+++ b/chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js

@@ -13,7 +13,6 @@ goog.require('cvox.BrailleBackground');

goog.require('cvox.BrailleTable');

goog.require('cvox.ChromeEarcons');

goog.require('cvox.ChromeHost');

-goog.require('cvox.ChromeMsgs');

goog.require('cvox.ChromeTts');

goog.require('cvox.ChromeVox');

goog.require('cvox.ChromeVoxPrefs');

@@ -22,6 +21,7 @@ goog.require('cvox.ExtensionBridge');

goog.require('cvox.HostFactory');

goog.require('cvox.KeyMap');

goog.require('cvox.KeySequence');

+goog.require('cvox.Msgs');

goog.require('cvox.PlatformFilter');

goog.require('cvox.PlatformUtil');

@@ -67,7 +67,7 @@ cvox.OptionsPage.TEXT_TO_KEYCODE = {

* @suppress {missingProperties} Property prefs never defined on Window

cvox.OptionsPage.init = function() {

- cvox.ChromeVox.msgs = cvox.HostFactory.getMsgs();

+ cvox.ChromeVox.msgs = new cvox.Msgs();

cvox.OptionsPage.prefs = chrome.extension.getBackgroundPage().prefs;

cvox.OptionsPage.populateKeyMapSelect();