Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 593123003: DevTools: make console.timeline/timelineEnd work for tracing based Timeline (Closed)

Created:
6 years, 3 months ago by yurys
Modified:
6 years, 3 months ago
Reviewers:
caseq, alph, pfeldman, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: make console.timeline/timelineEnd work for tracing based Timeline * console.timeline/timelineEnd doesn't start/stop timeline recording when tracing backend is used, instead they will result in a pair of blink.console async events similar to console.time/timeEnd. This will allow to easily select corresponding interval on the recorded timeline. * console.timeline/timelineEnd will produce deprecation warnings in the console. The users should start using console.time/timeEnd instead. BUG=412782 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182511

Patch Set 1 #

Patch Set 2 : Introduced formatTimelineTitle #

Patch Set 3 : Marked console.timeline/timelineEnd with DeprecateAs #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 6

Patch Set 6 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -110 lines) Patch
M LayoutTests/inspector/console/console-timeline-expected.txt View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A + LayoutTests/inspector/tracing/console-timeline.html View 4 chunks +57 lines, -39 lines 0 comments Download
A LayoutTests/inspector/tracing/console-timeline-expected.txt View 1 2 3 4 5 1 chunk +83 lines, -0 lines 0 comments Download
M Source/core/frame/ConsoleBase.cpp View 1 1 chunk +11 lines, -0 lines 0 comments Download
M Source/core/frame/ConsoleBase.idl View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorConsoleAgent.h View 1 2 3 chunks +1 line, -3 lines 0 comments Download
M Source/core/inspector/InspectorConsoleAgent.cpp View 1 2 4 chunks +3 lines, -10 lines 0 comments Download
M Source/core/inspector/InspectorController.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorTracingAgent.h View 1 2 3 4 2 chunks +0 lines, -6 lines 0 comments Download
M Source/core/inspector/InspectorTracingAgent.cpp View 1 2 3 4 3 chunks +8 lines, -41 lines 0 comments Download
M Source/core/inspector/PageConsoleAgent.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/inspector/PageConsoleAgent.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/WorkerConsoleAgent.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TracingModel.js View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
yurys
I'm hesitant on adding the warning to console.timeline/timelineEnd in case of "old" Timeline implementation but ...
6 years, 3 months ago (2014-09-23 14:08:35 UTC) #2
alph
lgtm https://codereview.chromium.org/593123003/diff/80001/Source/core/frame/UseCounter.cpp File Source/core/frame/UseCounter.cpp (right): https://codereview.chromium.org/593123003/diff/80001/Source/core/frame/UseCounter.cpp#newcode790 Source/core/frame/UseCounter.cpp:790: return "console.timeline is deprecated. Please use the console.time ...
6 years, 3 months ago (2014-09-23 16:02:07 UTC) #3
yurys
https://codereview.chromium.org/593123003/diff/80001/Source/core/frame/UseCounter.cpp File Source/core/frame/UseCounter.cpp (right): https://codereview.chromium.org/593123003/diff/80001/Source/core/frame/UseCounter.cpp#newcode790 Source/core/frame/UseCounter.cpp:790: return "console.timeline is deprecated. Please use the console.time instead."; ...
6 years, 3 months ago (2014-09-23 16:13:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/593123003/100001
6 years, 3 months ago (2014-09-23 16:14:28 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 18:09:22 UTC) #7
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as 182511

Powered by Google App Engine
This is Rietveld 408576698