Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: Source/core/frame/UseCounter.cpp

Issue 593123003: DevTools: make console.timeline/timelineEnd work for tracing based Timeline (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 1
2 /* 2 /*
3 * Copyright (C) 2012 Google, Inc. All rights reserved. 3 * Copyright (C) 2012 Google, Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 768 matching lines...) Expand 10 before | Expand all | Expand 10 after
779 779
780 case PictureSourceSrc: 780 case PictureSourceSrc:
781 return "<source src> with a <picture> parent is invalid and therefore ig nored. Please use <source srcset> instead."; 781 return "<source src> with a <picture> parent is invalid and therefore ig nored. Please use <source srcset> instead.";
782 782
783 case XHRProgressEventPosition: 783 case XHRProgressEventPosition:
784 return "The XMLHttpRequest progress event property 'position' is depreca ted. Please use 'loaded' instead."; 784 return "The XMLHttpRequest progress event property 'position' is depreca ted. Please use 'loaded' instead.";
785 785
786 case XHRProgressEventTotalSize: 786 case XHRProgressEventTotalSize:
787 return "The XMLHttpRequest progress event property 'totalSize' is deprec ated. Please use 'total' instead."; 787 return "The XMLHttpRequest progress event property 'totalSize' is deprec ated. Please use 'total' instead.";
788 788
789 case ConsoleTimeline:
790 return "console.timeline is deprecated. Please use the console.time inst ead.";
alph 2014/09/23 16:02:06 drop 'the'
yurys 2014/09/23 16:13:28 I copied the wording from case ConsoleMarkTimeline
791
792 case ConsoleTimelineEnd:
793 return "console.timelineEnd is deprecated. Please use the console.timeEn d instead.";
alph 2014/09/23 16:02:07 ditto
yurys 2014/09/23 16:13:28 I copied the wording from case ConsoleMarkTimeline
794
789 // Features that aren't deprecated don't have a deprecation message. 795 // Features that aren't deprecated don't have a deprecation message.
790 default: 796 default:
791 return String(); 797 return String();
792 } 798 }
793 } 799 }
794 800
795 void UseCounter::count(CSSParserContext context, CSSPropertyID feature) 801 void UseCounter::count(CSSParserContext context, CSSPropertyID feature)
796 { 802 {
797 ASSERT(feature >= firstCSSProperty); 803 ASSERT(feature >= firstCSSProperty);
798 ASSERT(feature <= lastCSSProperty); 804 ASSERT(feature <= lastCSSProperty);
(...skipping 28 matching lines...) Expand all
827 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents) 833 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents)
828 { 834 {
829 // FIXME: We may want to handle stylesheets that have multiple owners 835 // FIXME: We may want to handle stylesheets that have multiple owners
830 // http://crbug.com/242125 836 // http://crbug.com/242125
831 if (sheetContents && sheetContents->hasSingleOwnerNode()) 837 if (sheetContents && sheetContents->hasSingleOwnerNode())
832 return getFrom(sheetContents->singleOwnerDocument()); 838 return getFrom(sheetContents->singleOwnerDocument());
833 return 0; 839 return 0;
834 } 840 }
835 841
836 } // namespace blink 842 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698