Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 592793004: Move inline som functions ScopedDBusError into a .cc file (Closed)

Created:
6 years, 2 months ago by Alex Vakulenko
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move inline som functions ScopedDBusError into a .cc file dbus::ScopedDBusError has inline constructor/destructor and is_set() method that call into libdbus-1. By placing these function calls in a header file, we add implicit link dependency on components that need to use ScopedDBusError. If we move them out to a .cc file, the dependency will be localized to libchrome. BUG=chromium:416628 TEST=dbus_unittests pass Committed: https://crrev.com/7c5b40c126928ab99f86a973994243ed7f765250 Cr-Commit-Position: refs/heads/master@{#296478}

Patch Set 1 #

Patch Set 2 : Fixed a link-time issue of methods not being exported #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -9 lines) Patch
M dbus/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M dbus/dbus.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M dbus/scoped_dbus_error.h View 1 1 chunk +8 lines, -9 lines 0 comments Download
A dbus/scoped_dbus_error.cc View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Alex Vakulenko (Google)
6 years, 2 months ago (2014-09-22 22:36:53 UTC) #3
satorux1
LGTM
6 years, 2 months ago (2014-09-24 03:12:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/592793004/1
6 years, 2 months ago (2014-09-24 03:13:31 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/1644)
6 years, 2 months ago (2014-09-24 03:36:31 UTC) #8
Alex Vakulenko (Google)
On 2014/09/24 03:36:31, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 2 months ago (2014-09-24 14:36:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/592793004/20001
6 years, 2 months ago (2014-09-24 18:07:23 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 95ddf1e2af32f644ceb6bbb5f178fc682176b6d3
6 years, 2 months ago (2014-09-24 18:47:58 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-09-24 18:49:12 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7c5b40c126928ab99f86a973994243ed7f765250
Cr-Commit-Position: refs/heads/master@{#296478}

Powered by Google App Engine
This is Rietveld 408576698