Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: dbus/scoped_dbus_error.h

Issue 592793004: Move inline som functions ScopedDBusError into a .cc file (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed a link-time issue of methods not being exported Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dbus/dbus.gyp ('k') | dbus/scoped_dbus_error.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dbus/scoped_dbus_error.h
diff --git a/dbus/scoped_dbus_error.h b/dbus/scoped_dbus_error.h
index c15c44397b91c59e21d871228b048f64c241ac55..1484dbb81b4b300dd6cd874287b07e7ff1b85271 100644
--- a/dbus/scoped_dbus_error.h
+++ b/dbus/scoped_dbus_error.h
@@ -7,21 +7,20 @@
#include <dbus/dbus.h>
+#include "dbus/dbus_export.h"
+
namespace dbus {
// Utility class to ensure that DBusError is freed.
-class ScopedDBusError {
+class CHROME_DBUS_EXPORT ScopedDBusError {
public:
- ScopedDBusError() {
- dbus_error_init(&error_);
- }
-
- ~ScopedDBusError() {
- dbus_error_free(&error_);
- }
+ // Do not inline methods that call dbus_error_xxx() functions.
+ // See http://crbug.com/416628
+ ScopedDBusError();
+ ~ScopedDBusError();
DBusError* get() { return &error_; }
- bool is_set() const { return dbus_error_is_set(&error_); }
+ bool is_set() const;
const char* name() { return error_.name; }
const char* message() { return error_.message; }
« no previous file with comments | « dbus/dbus.gyp ('k') | dbus/scoped_dbus_error.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698