Issue 592753005: Make EnrollmentScreen::SetParameters() idempotent.

Issue 592753005: Make EnrollmentScreen::SetParameters() idempotent. (Closed)

Created:
6 years, 3 months ago by Thiemo Nagel

Modified:
6 years, 3 months ago

Reviewers:
Joao da Silva, Zachary Kuznia

CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Make EnrollmentScreen::SetParameters() idempotent. BUG=none Committed: https://crrev.com/da0fef4c46a2054a1b4202f1dcee66356a6e7543 Cr-Commit-Position: refs/heads/master@{#296165}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/chromeos/login/enrollment/enrollment_screen.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 9 (2 generated)

Thiemo Nagel

Hi Zachary, Joao, this is a minor code health issue, could you please take a ...

6 years, 3 months ago (2014-09-22 17:50:37 UTC) #2

Thiemo Nagel

On 2014/09/23 09:24:45, Joao da Silva wrote: > lgtm Thank you!

6 years, 3 months ago (2014-09-23 09:26:08 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/592753005/1

6 years, 3 months ago (2014-09-23 09:27:08 UTC) #7

commit-bot: I haz the power

Committed patchset #1 (id:1) as faf6275889ec66c00261ecf5a339eb7bee19d8ef

6 years, 3 months ago (2014-09-23 10:05:23 UTC) #8

commit-bot: I haz the power

6 years, 3 months ago (2014-09-23 10:06:21 UTC) #9

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/da0fef4c46a2054a1b4202f1dcee66356a6e7543
Cr-Commit-Position: refs/heads/master@{#296165}