chrome/browser/chromeos/login/enrollment/enrollment_screen.cc - Issue 592753005: Make EnrollmentScreen::SetParameters() idempotent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/enrollment/enrollment_screen.cc

Issue 592753005: Make EnrollmentScreen::SetParameters() idempotent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/login/enrollment/enrollment_screen.cc

diff --git a/chrome/browser/chromeos/login/enrollment/enrollment_screen.cc b/chrome/browser/chromeos/login/enrollment/enrollment_screen.cc

index a3bfa3bc7cf5af20db8a612b0d12a392045177c5..7217b30f6d90cca8c8276a13d778a9c8163ade61 100644

--- a/chrome/browser/chromeos/login/enrollment/enrollment_screen.cc

+++ b/chrome/browser/chromeos/login/enrollment/enrollment_screen.cc

@@ -73,7 +73,8 @@ void EnrollmentScreen::SetParameters(

user_ = user.empty() ? user : gaia::CanonicalizeEmail(user);

auth_token_ = auth_token;

shark_controller_ = shark_controller;

- DCHECK(!remora_controller_);

+ if (remora_controller_)

+ remora_controller_->RemoveObserver(this);

remora_controller_ = remora_controller;

if (remora_controller_)

remora_controller_->AddObserver(this);

« no previous file with comments | « no previous file | no next file » | no next file with comments »