Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(889)

Issue 592673002: Oilpan: tighten up allowed allocation of some types. (Closed)

Created:
6 years, 3 months ago by sof
Modified:
6 years, 3 months ago
CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org, oilpan-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Oilpan: tighten up allowed allocation of some types. No need to support these objects as being part of collections; adjust macro usage. R=ager BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182398

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/core/loader/FrameLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/NavigationScheduler.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/FrameTree.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
Please take a look.
6 years, 3 months ago (2014-09-22 07:24:42 UTC) #2
Mads Ager (chromium)
LGTM
6 years, 3 months ago (2014-09-22 07:31:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/592673002/1
6 years, 3 months ago (2014-09-22 07:40:47 UTC) #6
haraken
LGTM
6 years, 3 months ago (2014-09-22 08:01:34 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 08:51:51 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 182398

Powered by Google App Engine
This is Rietveld 408576698