Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Issue 592503002: Revert of Reland of "Remove void** from disk_cache interface." (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, cbentzel+watch_chromium.org, serviceworker-reviews, gavinp+disk_chromium.org, tzik, horo+watch_chromium.org, jam, nhiroki, darin-cc_chromium.org, piman+watch_chromium.org, kinuko+serviceworker
Base URL:
https://chromium.googlesource.com/chromium/src.git@1-webcacheimpl
Project:
chromium
Visibility:
Public.

Description

Revert of Reland of "Remove void** from disk_cache interface." (patchset #2 id:40001 of https://codereview.chromium.org/583283002/) Reason for revert: Suspected for causing accessibility tests to flake. Original issue's description: > Reland of "Remove void** from disk_cache interface." > > Enumeration and iteration were passing around void**. With this CL, we > instead use an Iterator object. > > TBR=clamy@chromium.org,jkarlin@chromium.org,jsbell@chromium.org > BUG=413644 > > Committed: https://crrev.com/edbfba945a76d97383122a01529abfe3ce63d34d > Cr-Commit-Position: refs/heads/master@{#295870} TBR=clamy@chromium.org,jkarlin@chromium.org,jsbell@chromium.org,rvargas@chromium.org,gavinp@chromium.org NOTREECHECKS=true NOTRY=true BUG=413644 Committed: https://crrev.com/ac2c408b1930266531c0c3c4ad429c0652e4748a Cr-Commit-Position: refs/heads/master@{#295887}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+355 lines, -367 lines) Patch
M content/browser/gpu/shader_disk_cache.cc View 4 chunks +8 lines, -6 lines 0 comments Download
M content/browser/service_worker/service_worker_cache.cc View 5 chunks +11 lines, -6 lines 0 comments Download
M net/disk_cache/backend_unittest.cc View 29 chunks +81 lines, -77 lines 0 comments Download
M net/disk_cache/blockfile/backend_impl.h View 1 chunk +3 lines, -10 lines 0 comments Download
M net/disk_cache/blockfile/backend_impl.cc View 1 chunk +10 lines, -26 lines 0 comments Download
M net/disk_cache/blockfile/backend_impl_v3.h View 1 chunk +3 lines, -3 lines 0 comments Download
M net/disk_cache/blockfile/backend_impl_v3.cc View 2 chunks +18 lines, -32 lines 0 comments Download
M net/disk_cache/disk_cache.h View 3 chunks +25 lines, -24 lines 0 comments Download
M net/disk_cache/disk_cache_test_base.h View 3 chunks +1 line, -13 lines 0 comments Download
M net/disk_cache/disk_cache_test_base.cc View 2 chunks +5 lines, -17 lines 0 comments Download
M net/disk_cache/entry_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/disk_cache/memory/mem_backend_impl.h View 4 chunks +4 lines, -7 lines 0 comments Download
M net/disk_cache/memory/mem_backend_impl.cc View 3 chunks +28 lines, -36 lines 0 comments Download
M net/disk_cache/simple/simple_backend_impl.h View 7 chunks +36 lines, -9 lines 0 comments Download
M net/disk_cache/simple/simple_backend_impl.cc View 4 chunks +88 lines, -72 lines 0 comments Download
M net/http/mock_http_cache.h View 2 chunks +3 lines, -2 lines 0 comments Download
M net/http/mock_http_cache.cc View 1 chunk +6 lines, -10 lines 0 comments Download
M net/tools/dump_cache/simple_cache_dumper.h View 2 chunks +6 lines, -2 lines 0 comments Download
M net/tools/dump_cache/simple_cache_dumper.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M net/url_request/view_cache_helper.h View 2 chunks +6 lines, -2 lines 0 comments Download
M net/url_request/view_cache_helper.cc View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dcheng
Created Revert of Reland of "Remove void** from disk_cache interface."
6 years, 3 months ago (2014-09-20 19:46:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/592503002/1
6 years, 3 months ago (2014-09-20 19:47:19 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 3d22dec2ffd5937676e8184d3a10f6f48f504763
6 years, 3 months ago (2014-09-20 19:47:46 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-20 19:48:15 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ac2c408b1930266531c0c3c4ad429c0652e4748a
Cr-Commit-Position: refs/heads/master@{#295887}

Powered by Google App Engine
This is Rietveld 408576698