net/http/mock_http_cache.h - Issue 592503002: Revert of Reland of "Remove void** from disk_cache interface."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/mock_http_cache.h

Issue 592503002: Revert of Reland of "Remove void** from disk_cache interface." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@1-webcacheimpl

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/mock_http_cache.h

diff --git a/net/http/mock_http_cache.h b/net/http/mock_http_cache.h

index ab63b114f55212586027138a5db98af8f6dc171c..5ead727b76a7f873dfd111215ac3dc53fac8946e 100644

--- a/net/http/mock_http_cache.h

+++ b/net/http/mock_http_cache.h

@@ -114,7 +114,9 @@

virtual int DoomEntriesSince(

base::Time initial_time,

const net::CompletionCallback& callback) OVERRIDE;

- virtual scoped_ptr<Iterator> CreateIterator() OVERRIDE;

+ virtual int OpenNextEntry(void** iter, disk_cache::Entry** next_entry,

+ const net::CompletionCallback& callback) OVERRIDE;

+ virtual void EndEnumeration(void** iter) OVERRIDE;

virtual void GetStats(

std::vector<std::pair<std::string, std::string> >* stats) OVERRIDE;

virtual void OnExternalCacheHit(const std::string& key) OVERRIDE;

@@ -141,7 +143,6 @@

private:

typedef base::hash_map<std::string, MockDiskEntry*> EntryMap;

- class NotImplementedIterator;

void CallbackLater(const net::CompletionCallback& callback, int result);

« no previous file with comments | « net/disk_cache/simple/simple_backend_impl.cc ('k') | net/http/mock_http_cache.cc » ('j') | no next file with comments »