Change ShowBubbleOnInactiveTabShouldDoNothing to not use GetTopLevelNativeWindow

Change ShowBubbleOnInactiveTabShouldDoNothing to not use GetTopLevelNativeWindow

Change this ManagePasswordsBubbleCocoaTest to use the tab strip model API
active_index() to determine if tab content is active.

TBR=rohitrao
BUG=417253
Committed: https://crrev.com/b96dffdfbe3f5beda0ab24bc0d4688c71dfd6286
Cr-Commit-Position: refs/heads/master@{#296431}

[Noel Gordon, 2014-09-24 13:51:46]

noel@chromium.org changed reviewers:
+ dconnelly@chromium.org, tapted@chromium.org

[dconnelly, 2014-09-24 13:57:31]

lgtm

https://codereview.chromium.org/592353005/diff/1/chrome/browser/ui/cocoa/pass...
File chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_cocoa_unittest.mm
(right):

https://codereview.chromium.org/592353005/diff/1/chrome/browser/ui/cocoa/pass...
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_cocoa_unittest.mm:109:
TabStripModel* tab_strip_model = browser()->tab_strip_model();
Nit: ObjC++ files use Cocoa naming conventions, which means mixedCase.

[Noel Gordon, 2014-09-24 14:11:56]

Thanks, I just looked at your patch https://codereview.chromium.org/528213004
and I think should update manage_passwords_bubble_cocoa.mm also ...

PTAL.

[dconnelly, 2014-09-24 14:18:30]

lgtm

[Noel Gordon, 2014-09-24 15:12:47]

noel@chromium.org changed reviewers:
+ rohitrao@chromium.org

[Noel Gordon, 2014-09-24 15:34:06]

Landing the unittest change only.

I suspect that manage_passwords_bubble_cocoa.mm is not the only example of OSX
code using GetTopLevelNativeWindow to detect if a tab is active or not.  So
leaving it out, updated the bug details.

[Noel Gordon, 2014-09-24 15:34:48]

The CQ bit was checked by noel@chromium.org

[commit-bot: I haz the power, 2014-09-24 15:35:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/592353005/60001

[commit-bot: I haz the power, 2014-09-24 16:14:17]

Committed patchset #4 (id:60001) as efc0170d65eed5c8fd82a2e0972824845d9a0fb9

[commit-bot: I haz the power, 2014-09-24 16:14:46]

Patchset 4 (id:??) landed as
https://crrev.com/b96dffdfbe3f5beda0ab24bc0d4688c71dfd6286
Cr-Commit-Position: refs/heads/master@{#296431}