Issue 528213004: Don't try to show the Mac password bubble on an inactive tab.

Issue 528213004: Don't try to show the Mac password bubble on an inactive tab. (Closed)

Created:
6 years, 3 months ago by dconnelly

Modified:
6 years, 3 months ago

Reviewers:
vabr (Chromium), rohitrao (ping after 24h)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Don't try to show the Mac password bubble on an inactive tab. Thanks to vabr@ for reproducing. BUG=409589 TBR=rohitrao Committed: https://crrev.com/a912b886f2d7d8da4b6e2ef89a32467b9c20748a Cr-Commit-Position: refs/heads/master@{#293118}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -14 lines)			Patch
	M	chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_cocoa.mm	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_cocoa_unittest.mm	View	1 2	3 chunks	+29 lines, -14 lines	0 comments	Download

Total messages: 8 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dconnelly@chromium.org/528213004/40001

6 years, 3 months ago (2014-09-03 10:20:14 UTC) #5

commit-bot: I haz the power

Committed patchset #3 (id:40001) as 76c3e750c654a6044e0d48dcf84aa885eb9b39a8

6 years, 3 months ago (2014-09-03 11:18:23 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:25:11 UTC) #8

Message was sent while issue was closed.

Patchset 3 (id:??) landed as
https://crrev.com/a912b886f2d7d8da4b6e2ef89a32467b9c20748a
Cr-Commit-Position: refs/heads/master@{#293118}