Source/core/html/HTMLMediaElement.h - Issue 59233014: Setting HTMLMediaElement.controller does not properly remove the 'mediagroup' content attribute

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLMediaElement.h

Issue 59233014: Setting HTMLMediaElement.controller does not properly remove the 'mediagroup' content attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/v8/custom/V8HTMLMediaElementCustom.cpp ('K') | « Source/bindings/v8/custom/V8HTMLMediaElementCustom.cpp ('k') | Source/core/html/HTMLMediaElement.cpp » ('j') | Source/core/html/HTMLMediaElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLMediaElement.h

diff --git a/Source/core/html/HTMLMediaElement.h b/Source/core/html/HTMLMediaElement.h

index 6fa04cbbed32896a96947ca3d955e99ac07b1add..fb0bc9616c6d50599d57f13f3f7ba13c075a69f8 100644

--- a/Source/core/html/HTMLMediaElement.h

+++ b/Source/core/html/HTMLMediaElement.h

@@ -279,7 +279,7 @@ public:

void setMediaGroup(const String&);

MediaController* controller() const;

- void setController(PassRefPtr<MediaController>);

+ void setController(PassRefPtr<MediaController>); // Resets the MediaGroup and sets the MediaController.

protected:

HTMLMediaElement(const QualifiedName&, Document&, bool);

@@ -298,6 +298,8 @@ protected:

virtual bool isMediaElement() const OVERRIDE { return true; }

+ void setControllerInternal(PassRefPtr<MediaController>);

// Restrictions to change default behaviors.

enum BehaviorRestrictionFlags {

NoRestrictions = 0,