Setting HTMLMediaElement.controller does not properly remove the 'mediagroup' content attribute

Source/bindings/v8/custom/V8HTMLMediaElementCustom.cpp

Index: Source/bindings/v8/custom/V8HTMLMediaElementCustom.cpp
diff --git a/Source/bindings/v8/custom/V8HTMLMediaElementCustom.cpp b/Source/bindings/v8/custom/V8HTMLMediaElementCustom.cpp
deleted file mode 100644
index fe6d6c3ccc73819b15bc1e8318a853c331886c43..0000000000000000000000000000000000000000
--- a/Source/bindings/v8/custom/V8HTMLMediaElementCustom.cpp
+++ /dev/null
@@ -1,52 +0,0 @@
-/*
- * Copyright (C) 2011 Apple Inc. All Rights Reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *    notice, this list of conditions and the following disclaimer in the
- *    documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
- * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
- * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE INC. OR
- * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
- * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
- * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
- * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
- * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include "config.h"
-#include "V8HTMLMediaElement.h"
-
-#include "V8MediaController.h"
-
-namespace WebCore {
-
-void V8HTMLMediaElement::controllerAttributeSetterCustom(v8::Local<v8::Value> value, const v8::PropertyCallbackInfo<void>& info)
-{
-    MediaController* controller = 0;
-    if (!value->IsNull()) {

[haraken, 2013/11/07 23:31:35]

Won't this CL change existing behavior when undefined is passed to |value|?

Could you add a test case of |value|=undefined?

[Inactive, 2013/11/08 15:35:38]

Yes, you are right that the generated handles undefined differently than the
custom one. We used to throw when given undefined and now we treat it as null.
The compatibility risk is low but you are right that it should be highlighted in
the Changelog and covered by layout test.

-        if (!V8MediaController::HasInstance(value, info.GetIsolate(), worldType(info.GetIsolate()))) {
-            throwTypeError("Value is not of type MediaController", info.GetIsolate());
-            return;
-        }
-        controller = V8MediaController::toNative(value->ToObject());
-    }
-
-    // 4.8.10.11.2 Media controllers: controller attribute.
-    // On setting, it must first remove the element's mediagroup attribute, if any,
-    HTMLMediaElement* imp = V8HTMLMediaElement::toNative(info.Holder());
-    imp->setMediaGroup(String());
-    // and then set the current media controller to the given value.
-    imp->setController(controller);
-}
-
-}