Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 592323002: [Mac] On pressing Esc key, close Bookmark Bubble without editing. (Closed)

Created:
6 years, 3 months ago by Gaja
Modified:
6 years, 3 months ago
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Mac] On pressing Esc key, close Bookmark Bubble without editing. Dismiss the bubble without updating changes to the node. BUG=329459 R=asvitkine@chromium.org TEST= 1. Launch chrome, press "Cmd+Shift+D" to "Show Bookmarks Bar" 2. Navigate to any webpage or new tab & press "Cmd+D" to open bookmark window and then press "Enter" key 3. On the same page, again press "Cmd+D" and change the page name in bookmark bubble window 4. Now press "Esc" key and observe 5. On pressing "Esc" key, bubble should get closed without making any changes to the bookmark Committed: https://crrev.com/e3ed8486c32c888cc268795c61d4c95e9b07986d Cr-Commit-Position: refs/heads/master@{#296239}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Gaja
@asvitkine PTAL.
6 years, 3 months ago (2014-09-23 06:27:51 UTC) #1
Alexei Svitkine (slow)
lgtm
6 years, 3 months ago (2014-09-23 17:00:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/592323002/1
6 years, 3 months ago (2014-09-23 17:59:29 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 6790ec7a3d7048ccffbe8a70638afad8b1abcf3d
6 years, 3 months ago (2014-09-23 21:05:59 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 21:06:48 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3ed8486c32c888cc268795c61d4c95e9b07986d
Cr-Commit-Position: refs/heads/master@{#296239}

Powered by Google App Engine
This is Rietveld 408576698