chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm - Issue 592323002: [Mac] On pressing Esc key, close Bookmark Bubble without editing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm

Issue 592323002: [Mac] On pressing Esc key, close Bookmark Bubble without editing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm

index d988c8d2cee78854ec05b197998e7e1f30935a36..74c758ad225c6a5d0d4441d30a801240daedc29d 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm

@@ -250,7 +250,8 @@ using base::UserMetricsAction;

// |-remove:| calls |-close| so don't do it.

[self remove:sender];

} else {

- [self ok:sender];

+ [self stopPulsingBookmarkButton];

+ [self dismissWithoutEditing:nil];

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »