Issue 592173002: Use FORCE_64BIT_ALIGN to make sure that aes_cbc_ctx_t allocated by aes_cbc_alloc is 64-bit aligned.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 592173002: Use FORCE_64BIT_ALIGN to make sure that aes_cbc_ctx_t allocated by aes_cbc_alloc is 64-bit aligned. (Closed)

Created:
6 years, 3 months ago by jiayl

Modified:
6 years, 3 months ago

Reviewers:
Sergey Ulanov

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/deps/third_party/libsrtp/

Project:
chromium_deps

Visibility:
Public.

More Reviews

Description

Use FORCE_64BIT_ALIGN on 32-bit platforms to make sure that aes_cbc_ctx_t allocated by aes_cbc_alloc is 64-bit aligned. BUG=414919 R=sergeyu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=292077

Patch Set 2 : #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	libsrtp.gyp	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Sergey Ulanov

LGTM, but please address my comment. https://codereview.chromium.org/592173002/diff/1/libsrtp.gyp File libsrtp.gyp (right): https://codereview.chromium.org/592173002/diff/1/libsrtp.gyp#newcode67 libsrtp.gyp:67: # crbug/414919. It ...

6 years, 3 months ago (2014-09-22 21:57:52 UTC) #2

jiayl

6 years, 3 months ago (2014-09-22 22:04:36 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as r292077 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 592173002: Use FORCE_64BIT_ALIGN to make sure that aes_cbc_ctx_t allocated by aes_cbc_alloc is 64-bit aligned. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages