Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: libsrtp.gyp

Issue 592173002: Use FORCE_64BIT_ALIGN to make sure that aes_cbc_ctx_t allocated by aes_cbc_alloc is 64-bit aligned. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/deps/third_party/libsrtp/
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: libsrtp.gyp
===================================================================
--- libsrtp.gyp (revision 292049)
+++ libsrtp.gyp (working copy)
@@ -61,6 +61,16 @@
'CPU_RISC',
],
}],
+ ['target_arch=="mipsel" or target_arch=="arm" or target_arch=="armv7" or target_arch=="ia32"', {
+ 'defines': [
+ # Define FORCE_64BIT_ALIGN to avoid alignment-related-crashes like
+ # crbug/414919. Without this, aes_cbc_alloc will allocate an
+ # aes_cbc_ctx_t not 64-bit aligned and the v128_t members of
+ # aes_cbc_ctx_t will not be 64-bit aligned, which breaks the
+ # compiler optimizations that assume 64-bit alignment of v128_t.
+ 'FORCE_64BIT_ALIGN',
+ ],
+ }],
],
'direct_dependent_settings': {
'include_dirs': [
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698