Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 591573002: Mojo: Remove Channel::AttachMessagePipeEndpoint(). (Closed)

Created:
6 years, 3 months ago by viettrungluu
Modified:
6 years, 3 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mojo: Remove Channel::AttachMessagePipeEndpoint(). (Convert all uses to AttachEndpoint(). This means that Channel will no longer create ChannelEndpoints.) R=darin@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/ae1766cd9cc3f3c8708d62f77450c62ceed5acc7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -68 lines) Patch
M mojo/embedder/embedder.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M mojo/system/channel.h View 4 chunks +9 lines, -26 lines 0 comments Download
M mojo/system/channel.cc View 3 chunks +2 lines, -12 lines 0 comments Download
M mojo/system/channel_endpoint.h View 1 chunk +0 lines, -5 lines 0 comments Download
M mojo/system/channel_unittest.cc View 5 chunks +14 lines, -13 lines 0 comments Download
M mojo/system/message_pipe_dispatcher.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M mojo/system/message_pipe_test_utils.cc View 2 chunks +3 lines, -1 line 0 comments Download
M mojo/system/remote_message_pipe_unittest.cc View 3 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
viettrungluu
6 years, 3 months ago (2014-09-19 19:37:35 UTC) #1
darin (slow to review)
lgtm
6 years, 3 months ago (2014-09-19 21:10:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/591573002/1
6 years, 3 months ago (2014-09-19 21:13:45 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ae1766cd9cc3f3c8708d62f77450c62ceed5acc7 Cr-Commit-Position: refs/heads/master@{#295788}
6 years, 3 months ago (2014-09-19 21:58:21 UTC) #5
viettrungluu
6 years, 3 months ago (2014-09-19 21:58:31 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as ae1766c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698