Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: mojo/system/channel_endpoint.h

Issue 591573002: Mojo: Remove Channel::AttachMessagePipeEndpoint(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/system/channel.cc ('k') | mojo/system/channel_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/system/channel_endpoint.h
diff --git a/mojo/system/channel_endpoint.h b/mojo/system/channel_endpoint.h
index 593ab5597f11bb8d00d9a13446b29d8150ca33ac..7d85b8e35e80cf7c057170387182dc25660a8e34 100644
--- a/mojo/system/channel_endpoint.h
+++ b/mojo/system/channel_endpoint.h
@@ -110,11 +110,6 @@ class MOJO_SYSTEM_IMPL_EXPORT ChannelEndpoint
: public base::RefCountedThreadSafe<ChannelEndpoint> {
public:
// TODO(vtl): More comments....
- // The caller must keep |channel| alive until the |Channel| has taken
- // ownership of a reference to the created object. (TODO(vtl): Convert
- // |Channel::AttachMessagePipeEndpoint()| to a |Channel::AttachEndpoint()|
- // that takes a |ChannelEndpoint|, and move |ChannelEndpoint| creation out of
- // |Channel|.)
ChannelEndpoint(MessagePipe* message_pipe, unsigned port);
// Methods called by |MessagePipe| (via |ProxyMessagePipeEndpoint|):
« no previous file with comments | « mojo/system/channel.cc ('k') | mojo/system/channel_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698