Different message for offline unlock, first time.

Different message for offline unlock, first time.

BUG=413271
TEST=Ensure new-profile-management is disabled. Sign in to a profile.
Enable new-profile-management. Lock an account. Take the machine
offline. Try to unlock your account (with the right or wrong password),
and receive a message specifying that your password cannot be
verified because you're offline.

Committed: https://crrev.com/47bc8df169555d7cf4896c7d9bee92167b85e4d8
Cr-Commit-Position: refs/heads/master@{#295965}

[Mike Lerman, 2014-09-19 17:09:02]

mlerman@chromium.org changed reviewers:
+ noms@chromium.org

[Mike Lerman, 2014-09-19 17:09:03]

Hi Monica,

Can you take a look at this please? Thanks!

Mike

[noms (inactive), 2014-09-19 17:38:09]

lgtm % nits

https://codereview.chromium.org/591533002/diff/1/chrome/browser/ui/webui/sign...
File chrome/browser/ui/webui/signin/user_manager_screen_handler.cc (right):

https://codereview.chromium.org/591533002/diff/1/chrome/browser/ui/webui/sign...
chrome/browser/ui/webui/signin/user_manager_screen_handler.cc:481: :
ProfileMetrics::AUTH_FAILED;
nit: put the : at the end of L480

https://codereview.chromium.org/591533002/diff/1/chrome/browser/ui/webui/sign...
chrome/browser/ui/webui/signin/user_manager_screen_handler.cc:696: ?
IDS_LOGIN_ERROR_AUTHENTICATING_OFFLINE
The ? and : should go to at the end of the line. Also, please put the
(auth==...) bit in brackets

[Mike Lerman, 2014-09-19 17:42:38]

mlerman@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Mike Lerman, 2014-09-19 17:42:38]

Alexei,

Can you please review this histograms change? Thanks!

Mike

[Alexei Svitkine (slow), 2014-09-19 17:46:30]

histograms lgtm

[Alexei Svitkine (slow), 2014-09-19 17:47:57]

+cc jwd

By the way, Jesse is now a metrics owner, so I'm hereby delegating future
identity metrics reviews to him. ;)

[Mike Lerman, 2014-09-19 17:50:11]

On 2014/09/19 17:47:57, Alexei Svitkine wrote:
> +cc jwd
> 
> By the way, Jesse is now a metrics owner, so I'm hereby delegating future
> identity metrics reviews to him. ;)

He is? Reitveld doesn't tell me such things. sgtm!

[Mike Lerman, 2014-09-19 19:07:07]

The CQ bit was checked by mlerman@chromium.org

[commit-bot: I haz the power, 2014-09-19 19:08:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/591533002/20001

[commit-bot: I haz the power, 2014-09-19 21:24:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-19 21:24:50]

Failed to apply the patch.

[Mike Lerman, 2014-09-22 13:07:37]

The CQ bit was checked by mlerman@chromium.org

[commit-bot: I haz the power, 2014-09-22 13:08:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/591533002/40001

[commit-bot: I haz the power, 2014-09-22 14:06:05]

Committed patchset #3 (id:40001) as 1fe07120fdae239cdeb574264e1dcf139dab4875

[commit-bot: I haz the power, 2014-09-22 14:06:41]

Patchset 3 (id:??) landed as
https://crrev.com/47bc8df169555d7cf4896c7d9bee92167b85e4d8
Cr-Commit-Position: refs/heads/master@{#295965}