Different message for offline unlock, first time.

chrome/browser/ui/webui/signin/user_manager_screen_handler.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/signin/user_manager_screen_handler.h"
 
 #include "base/bind.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/value_conversions.h"
@@ skipping 455 matching lines @@
     const GoogleServiceAuthError& error) {
   const GoogleServiceAuthError::State state = error.state();
   // Some "error" results mean the password was correct but some other action
   // should be taken.  For our purposes, we only care that the password was
   // correct so count those as a success.
   bool success = (state == GoogleServiceAuthError::NONE ||
                   state == GoogleServiceAuthError::CAPTCHA_REQUIRED ||
                   state == GoogleServiceAuthError::TWO_FACTOR ||
                   state == GoogleServiceAuthError::ACCOUNT_DELETED ||
                   state == GoogleServiceAuthError::ACCOUNT_DISABLED);
-  ReportAuthenticationResult(success,
-                             success ? ProfileMetrics::AUTH_ONLINE
-                                     : ProfileMetrics::AUTH_FAILED);
+  bool offline = (state == GoogleServiceAuthError::CONNECTION_FAILED ||
+                  state == GoogleServiceAuthError::SERVICE_UNAVAILABLE ||
+                  state == GoogleServiceAuthError::REQUEST_CANCELED);
+  ProfileMetrics::ProfileAuth failure_metric =
+      offline ? ProfileMetrics::AUTH_FAILED_OFFLINE
+              : ProfileMetrics::AUTH_FAILED;

[noms (inactive), 2014/09/19 17:38:09]

nit: put the : at the end of L480

+  ReportAuthenticationResult(
+      success, success ? ProfileMetrics::AUTH_ONLINE : failure_metric);
 }
 
 void UserManagerScreenHandler::RegisterMessages() {
   web_ui()->RegisterMessageCallback(kJsApiUserManagerInitialize,
       base::Bind(&UserManagerScreenHandler::HandleInitialize,
                  base::Unretained(this)));
   web_ui()->RegisterMessageCallback(kJsApiUserManagerAddUser,
       base::Bind(&UserManagerScreenHandler::HandleAddUser,
                  base::Unretained(this)));
   web_ui()->RegisterMessageCallback(kJsApiUserManagerAuthLaunchUser,
@@ skipping 190 matching lines @@
         authenticating_profile_index_, false);
     base::FilePath path = info_cache.GetPathOfProfileAtIndex(
         authenticating_profile_index_);
     profiles::SwitchToProfile(path, desktop_type_, true,
                               base::Bind(&OnSwitchToProfileComplete),
                               ProfileMetrics::SWITCH_PROFILE_UNLOCK);
   } else {
     web_ui()->CallJavascriptFunction(
         "cr.ui.Oobe.showSignInError",
         base::FundamentalValue(0),
-        base::StringValue(
-            l10n_util::GetStringUTF8(IDS_LOGIN_ERROR_AUTHENTICATING)),
+        base::StringValue(l10n_util::GetStringUTF8(
+            auth == ProfileMetrics::AUTH_FAILED_OFFLINE
+                ? IDS_LOGIN_ERROR_AUTHENTICATING_OFFLINE

[noms (inactive), 2014/09/19 17:38:09]

The ? and : should go to at the end of the line. Also, please put the
(auth==...) bit in brackets

+                : IDS_LOGIN_ERROR_AUTHENTICATING)),
         base::StringValue(""),
         base::FundamentalValue(0));
   }
 }