Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 59153007: Revert "Implement Math.sin, cos and tan using table lookup and spline interpolation." (Closed)

Created:
7 years, 1 month ago by Yang
Modified:
7 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Revert "Implement Math.sin, cos and tan using table lookup and spline interpolation." This reverts commit r17594. BUG= R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17596

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -271 lines) Patch
M src/arm/full-codegen-arm.cc View 2 chunks +33 lines, -7 lines 0 comments Download
M src/hydrogen.cc View 5 chunks +37 lines, -15 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 2 chunks +33 lines, -7 lines 0 comments Download
M src/math.js View 5 chunks +3 lines, -69 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 2 chunks +36 lines, -7 lines 0 comments Download
M src/objects.h View 4 chunks +3 lines, -7 lines 0 comments Download
M src/objects.cc View 2 chunks +14 lines, -10 lines 0 comments Download
M src/objects-inl.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/runtime.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/runtime.cc View 2 chunks +0 lines, -43 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 2 chunks +33 lines, -7 lines 0 comments Download
M test/mjsunit/sin-cos.js View 1 chunk +1 line, -93 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
7 years, 1 month ago (2013-11-08 13:43:25 UTC) #1
Toon Verwaest
(rubberstamp) lgtm
7 years, 1 month ago (2013-11-08 13:43:53 UTC) #2
Yang
7 years, 1 month ago (2013-11-08 13:45:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17596.

Powered by Google App Engine
This is Rietveld 408576698