Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Unified Diff: mojo/public/bindings/js/v8_exceptions.cc

Issue 59153005: Begin implementing V8 bindings for Mojo (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: spelling Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/bindings/js/v8_exceptions.cc
diff --git a/mojo/public/bindings/js/v8_exceptions.cc b/mojo/public/bindings/js/v8_exceptions.cc
new file mode 100644
index 0000000000000000000000000000000000000000..f5a1921ef1ce8b26800e60a8d987cf189dd0d740
--- /dev/null
+++ b/mojo/public/bindings/js/v8_exceptions.cc
@@ -0,0 +1,20 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "mojo/public/bindings/js/v8_exceptions.h"
+
+#include "mojo/public/bindings/js/v8_core.h"
+
+namespace mojo {
+namespace js {
+
+const char kInsufficientArguments[] = "Insufficient number of arguments.";
+
+void ThrowTypeError(v8::Isolate* isolate, const char* message) {
Aaron Boodman 2013/11/09 08:26:02 Nit: you are using 'type' error in cases where it'
abarth-chromium 2013/11/09 08:52:37 TypeError is what the we throw for insufficient ar
Aaron Boodman 2013/11/09 21:12:12 Oh, if that's what's in the IDL spec, that's a goo
+ v8::Handle<v8::String> string = v8::String::New(message);
+ isolate->ThrowException(v8::Exception::TypeError(string));
+}
+
+} // namespace js
+} // mojo

Powered by Google App Engine
This is Rietveld 408576698