Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Side by Side Diff: mojo/public/bindings/js/v8_exceptions.cc

Issue 59153005: Begin implementing V8 bindings for Mojo (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: spelling Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "mojo/public/bindings/js/v8_exceptions.h"
6
7 #include "mojo/public/bindings/js/v8_core.h"
8
9 namespace mojo {
10 namespace js {
11
12 const char kInsufficientArguments[] = "Insufficient number of arguments.";
13
14 void ThrowTypeError(v8::Isolate* isolate, const char* message) {
Aaron Boodman 2013/11/09 08:26:02 Nit: you are using 'type' error in cases where it'
abarth-chromium 2013/11/09 08:52:37 TypeError is what the we throw for insufficient ar
Aaron Boodman 2013/11/09 21:12:12 Oh, if that's what's in the IDL spec, that's a goo
15 v8::Handle<v8::String> string = v8::String::New(message);
16 isolate->ThrowException(v8::Exception::TypeError(string));
17 }
18
19 } // namespace js
20 } // mojo
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698