Chromium Code Reviews| Index: chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm |
| diff --git a/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm b/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm |
| index c9db177cbf6d6527b9e75fecf68ddcfb99ee987d..94ccad2ab7e86e3a1df27c5cdf6a42f1ec10b357 100644 |
| --- a/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm |
| +++ b/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm |
| @@ -48,13 +48,11 @@ IN_PROC_BROWSER_TEST_F(SSLClientCertificateSelectorCocoaTest, DISABLED_Basic) { |
| net::X509Certificate* cert = NULL; |
| int count = 0; |
| - SSLClientCertificateSelectorCocoa* selector = |
| - [[SSLClientCertificateSelectorCocoa alloc] |
| - initWithNetworkSession:auth_requestor_->http_network_session_ |
| - certRequestInfo:auth_requestor_->cert_request_info_ |
| - callback:base::Bind(&OnCertificateSelected, |
| - &cert, |
| - &count)]; |
| + SSLClientCertificateSelectorCocoa* selector = [ |
|
Lei Zhang
2014/09/19 18:38:59
nit: is this the preferred objc style?
dcheng
2014/09/19 19:23:47
I'm not sure. It looks like the formatter is aware
Robert Sesek
2014/09/19 20:26:01
clang-format technically has support for ObjC, but
|
| + [SSLClientCertificateSelectorCocoa alloc] |
| + initWithNetworkSession:auth_requestor_->http_network_session_ |
| + certRequestInfo:auth_requestor_->cert_request_info_.get() |
| + callback:base::Bind(&OnCertificateSelected, &cert, &count)]; |
| [selector displayForWebContents:web_contents]; |
| content::RunAllPendingInMessageLoop(); |
| EXPECT_TRUE([selector panel]); |
| @@ -75,7 +73,7 @@ IN_PROC_BROWSER_TEST_F(SSLClientCertificateSelectorCocoaTest, HideShow) { |
| SSLClientCertificateSelectorCocoa* selector = |
| [[SSLClientCertificateSelectorCocoa alloc] |
| initWithNetworkSession:auth_requestor_->http_network_session_ |
| - certRequestInfo:auth_requestor_->cert_request_info_ |
| + certRequestInfo:auth_requestor_->cert_request_info_.get() |
| callback:chrome::SelectCertificateCallback()]; |
| content::WebContents* web_contents = |
| browser()->tab_strip_model()->GetActiveWebContents(); |