Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 591393002: Made the detailed reason for deopts mandatory on ia32. Unified and improved things. (Closed)

Created:
6 years, 3 months ago by Sven Panne
Modified:
6 years, 3 months ago
Reviewers:
Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Made the detailed reason for deopts mandatory on ia32. Unified and improved things. The number of different detail strings has been reduced a bit without any loss of information. Furthermore, DoubleToI is a bit more informative now. Tiny reason fixes. R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24146

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -151 lines) Patch
M src/ia32/code-stubs-ia32.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 71 chunks +108 lines, -98 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 2 chunks +7 lines, -8 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 19 chunks +37 lines, -29 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 2 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Sven Panne
6 years, 3 months ago (2014-09-23 09:58:30 UTC) #2
Jarin
lgtm
6 years, 3 months ago (2014-09-23 10:54:33 UTC) #3
Sven Panne
6 years, 3 months ago (2014-09-23 11:38:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24146 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698