| Index: src/ia32/lithium-codegen-ia32.cc
|
| diff --git a/src/ia32/lithium-codegen-ia32.cc b/src/ia32/lithium-codegen-ia32.cc
|
| index 8490ff975cd3778968fde7e9710a5f667f31ef8a..7453cac53bc88e86c7fa4dcdb5d471a929089e92 100644
|
| --- a/src/ia32/lithium-codegen-ia32.cc
|
| +++ b/src/ia32/lithium-codegen-ia32.cc
|
| @@ -1121,7 +1121,7 @@ void LCodeGen::DoModByPowerOf2I(LModByPowerOf2I* instr) {
|
| __ and_(dividend, mask);
|
| __ neg(dividend);
|
| if (hmod->CheckFlag(HValue::kBailoutOnMinusZero)) {
|
| - DeoptimizeIf(zero, instr);
|
| + DeoptimizeIf(zero, instr, "minus zero");
|
| }
|
| __ jmp(&done, Label::kNear);
|
| }
|
| @@ -1138,7 +1138,7 @@ void LCodeGen::DoModByConstI(LModByConstI* instr) {
|
| DCHECK(ToRegister(instr->result()).is(eax));
|
|
|
| if (divisor == 0) {
|
| - DeoptimizeIf(no_condition, instr);
|
| + DeoptimizeIf(no_condition, instr, "division by zero");
|
| return;
|
| }
|
|
|
| @@ -1153,7 +1153,7 @@ void LCodeGen::DoModByConstI(LModByConstI* instr) {
|
| Label remainder_not_zero;
|
| __ j(not_zero, &remainder_not_zero, Label::kNear);
|
| __ cmp(dividend, Immediate(0));
|
| - DeoptimizeIf(less, instr);
|
| + DeoptimizeIf(less, instr, "minus zero");
|
| __ bind(&remainder_not_zero);
|
| }
|
| }
|
| @@ -1175,7 +1175,7 @@ void LCodeGen::DoModI(LModI* instr) {
|
| // deopt in this case because we can't return a NaN.
|
| if (hmod->CheckFlag(HValue::kCanBeDivByZero)) {
|
| __ test(right_reg, Operand(right_reg));
|
| - DeoptimizeIf(zero, instr);
|
| + DeoptimizeIf(zero, instr, "division by zero");
|
| }
|
|
|
| // Check for kMinInt % -1, idiv would signal a divide error. We
|
| @@ -1186,7 +1186,7 @@ void LCodeGen::DoModI(LModI* instr) {
|
| __ j(not_equal, &no_overflow_possible, Label::kNear);
|
| __ cmp(right_reg, -1);
|
| if (hmod->CheckFlag(HValue::kBailoutOnMinusZero)) {
|
| - DeoptimizeIf(equal, instr);
|
| + DeoptimizeIf(equal, instr, "minus zero");
|
| } else {
|
| __ j(not_equal, &no_overflow_possible, Label::kNear);
|
| __ Move(result_reg, Immediate(0));
|
| @@ -1205,7 +1205,7 @@ void LCodeGen::DoModI(LModI* instr) {
|
| __ j(not_sign, &positive_left, Label::kNear);
|
| __ idiv(right_reg);
|
| __ test(result_reg, Operand(result_reg));
|
| - DeoptimizeIf(zero, instr);
|
| + DeoptimizeIf(zero, instr, "minus zero");
|
| __ jmp(&done, Label::kNear);
|
| __ bind(&positive_left);
|
| }
|
| @@ -1225,19 +1225,19 @@ void LCodeGen::DoDivByPowerOf2I(LDivByPowerOf2I* instr) {
|
| HDiv* hdiv = instr->hydrogen();
|
| if (hdiv->CheckFlag(HValue::kBailoutOnMinusZero) && divisor < 0) {
|
| __ test(dividend, dividend);
|
| - DeoptimizeIf(zero, instr);
|
| + DeoptimizeIf(zero, instr, "minus zero");
|
| }
|
| // Check for (kMinInt / -1).
|
| if (hdiv->CheckFlag(HValue::kCanOverflow) && divisor == -1) {
|
| __ cmp(dividend, kMinInt);
|
| - DeoptimizeIf(zero, instr);
|
| + DeoptimizeIf(zero, instr, "overflow");
|
| }
|
| // Deoptimize if remainder will not be 0.
|
| if (!hdiv->CheckFlag(HInstruction::kAllUsesTruncatingToInt32) &&
|
| divisor != 1 && divisor != -1) {
|
| int32_t mask = divisor < 0 ? -(divisor + 1) : (divisor - 1);
|
| __ test(dividend, Immediate(mask));
|
| - DeoptimizeIf(not_zero, instr);
|
| + DeoptimizeIf(not_zero, instr, "lost precision");
|
| }
|
| __ Move(result, dividend);
|
| int32_t shift = WhichPowerOf2Abs(divisor);
|
| @@ -1258,7 +1258,7 @@ void LCodeGen::DoDivByConstI(LDivByConstI* instr) {
|
| DCHECK(ToRegister(instr->result()).is(edx));
|
|
|
| if (divisor == 0) {
|
| - DeoptimizeIf(no_condition, instr);
|
| + DeoptimizeIf(no_condition, instr, "division by zero");
|
| return;
|
| }
|
|
|
| @@ -1266,7 +1266,7 @@ void LCodeGen::DoDivByConstI(LDivByConstI* instr) {
|
| HDiv* hdiv = instr->hydrogen();
|
| if (hdiv->CheckFlag(HValue::kBailoutOnMinusZero) && divisor < 0) {
|
| __ test(dividend, dividend);
|
| - DeoptimizeIf(zero, instr);
|
| + DeoptimizeIf(zero, instr, "minus zero");
|
| }
|
|
|
| __ TruncatingDiv(dividend, Abs(divisor));
|
| @@ -1276,7 +1276,7 @@ void LCodeGen::DoDivByConstI(LDivByConstI* instr) {
|
| __ mov(eax, edx);
|
| __ imul(eax, eax, divisor);
|
| __ sub(eax, dividend);
|
| - DeoptimizeIf(not_equal, instr);
|
| + DeoptimizeIf(not_equal, instr, "lost precision");
|
| }
|
| }
|
|
|
| @@ -1296,7 +1296,7 @@ void LCodeGen::DoDivI(LDivI* instr) {
|
| // Check for x / 0.
|
| if (hdiv->CheckFlag(HValue::kCanBeDivByZero)) {
|
| __ test(divisor, divisor);
|
| - DeoptimizeIf(zero, instr);
|
| + DeoptimizeIf(zero, instr, "division by zero");
|
| }
|
|
|
| // Check for (0 / -x) that will produce negative zero.
|
| @@ -1305,7 +1305,7 @@ void LCodeGen::DoDivI(LDivI* instr) {
|
| __ test(dividend, dividend);
|
| __ j(not_zero, ÷nd_not_zero, Label::kNear);
|
| __ test(divisor, divisor);
|
| - DeoptimizeIf(sign, instr);
|
| + DeoptimizeIf(sign, instr, "minus zero");
|
| __ bind(÷nd_not_zero);
|
| }
|
|
|
| @@ -1315,7 +1315,7 @@ void LCodeGen::DoDivI(LDivI* instr) {
|
| __ cmp(dividend, kMinInt);
|
| __ j(not_zero, ÷nd_not_min_int, Label::kNear);
|
| __ cmp(divisor, -1);
|
| - DeoptimizeIf(zero, instr);
|
| + DeoptimizeIf(zero, instr, "overflow");
|
| __ bind(÷nd_not_min_int);
|
| }
|
|
|
| @@ -1326,7 +1326,7 @@ void LCodeGen::DoDivI(LDivI* instr) {
|
| if (!hdiv->CheckFlag(HValue::kAllUsesTruncatingToInt32)) {
|
| // Deoptimize if remainder is not 0.
|
| __ test(remainder, remainder);
|
| - DeoptimizeIf(not_zero, instr);
|
| + DeoptimizeIf(not_zero, instr, "lost precision");
|
| }
|
| }
|
|
|
| @@ -1348,13 +1348,13 @@ void LCodeGen::DoFlooringDivByPowerOf2I(LFlooringDivByPowerOf2I* instr) {
|
| // If the divisor is negative, we have to negate and handle edge cases.
|
| __ neg(dividend);
|
| if (instr->hydrogen()->CheckFlag(HValue::kBailoutOnMinusZero)) {
|
| - DeoptimizeIf(zero, instr);
|
| + DeoptimizeIf(zero, instr, "minus zero");
|
| }
|
|
|
| // Dividing by -1 is basically negation, unless we overflow.
|
| if (divisor == -1) {
|
| if (instr->hydrogen()->CheckFlag(HValue::kLeftCanBeMinInt)) {
|
| - DeoptimizeIf(overflow, instr);
|
| + DeoptimizeIf(overflow, instr, "overflow");
|
| }
|
| return;
|
| }
|
| @@ -1381,7 +1381,7 @@ void LCodeGen::DoFlooringDivByConstI(LFlooringDivByConstI* instr) {
|
| DCHECK(ToRegister(instr->result()).is(edx));
|
|
|
| if (divisor == 0) {
|
| - DeoptimizeIf(no_condition, instr);
|
| + DeoptimizeIf(no_condition, instr, "division by zero");
|
| return;
|
| }
|
|
|
| @@ -1389,7 +1389,7 @@ void LCodeGen::DoFlooringDivByConstI(LFlooringDivByConstI* instr) {
|
| HMathFloorOfDiv* hdiv = instr->hydrogen();
|
| if (hdiv->CheckFlag(HValue::kBailoutOnMinusZero) && divisor < 0) {
|
| __ test(dividend, dividend);
|
| - DeoptimizeIf(zero, instr);
|
| + DeoptimizeIf(zero, instr, "minus zero");
|
| }
|
|
|
| // Easy case: We need no dynamic check for the dividend and the flooring
|
| @@ -1436,7 +1436,7 @@ void LCodeGen::DoFlooringDivI(LFlooringDivI* instr) {
|
| // Check for x / 0.
|
| if (hdiv->CheckFlag(HValue::kCanBeDivByZero)) {
|
| __ test(divisor, divisor);
|
| - DeoptimizeIf(zero, instr);
|
| + DeoptimizeIf(zero, instr, "division by zero");
|
| }
|
|
|
| // Check for (0 / -x) that will produce negative zero.
|
| @@ -1445,7 +1445,7 @@ void LCodeGen::DoFlooringDivI(LFlooringDivI* instr) {
|
| __ test(dividend, dividend);
|
| __ j(not_zero, ÷nd_not_zero, Label::kNear);
|
| __ test(divisor, divisor);
|
| - DeoptimizeIf(sign, instr);
|
| + DeoptimizeIf(sign, instr, "minus zero");
|
| __ bind(÷nd_not_zero);
|
| }
|
|
|
| @@ -1455,7 +1455,7 @@ void LCodeGen::DoFlooringDivI(LFlooringDivI* instr) {
|
| __ cmp(dividend, kMinInt);
|
| __ j(not_zero, ÷nd_not_min_int, Label::kNear);
|
| __ cmp(divisor, -1);
|
| - DeoptimizeIf(zero, instr);
|
| + DeoptimizeIf(zero, instr, "overflow");
|
| __ bind(÷nd_not_min_int);
|
| }
|
|
|
| @@ -1533,7 +1533,7 @@ void LCodeGen::DoMulI(LMulI* instr) {
|
| }
|
|
|
| if (instr->hydrogen()->CheckFlag(HValue::kCanOverflow)) {
|
| - DeoptimizeIf(overflow, instr);
|
| + DeoptimizeIf(overflow, instr, "overflow");
|
| }
|
|
|
| if (instr->hydrogen()->CheckFlag(HValue::kBailoutOnMinusZero)) {
|
| @@ -1543,15 +1543,15 @@ void LCodeGen::DoMulI(LMulI* instr) {
|
| __ j(not_zero, &done, Label::kNear);
|
| if (right->IsConstantOperand()) {
|
| if (ToInteger32(LConstantOperand::cast(right)) < 0) {
|
| - DeoptimizeIf(no_condition, instr);
|
| + DeoptimizeIf(no_condition, instr, "minus zero");
|
| } else if (ToInteger32(LConstantOperand::cast(right)) == 0) {
|
| __ cmp(ToRegister(instr->temp()), Immediate(0));
|
| - DeoptimizeIf(less, instr);
|
| + DeoptimizeIf(less, instr, "minus zero");
|
| }
|
| } else {
|
| // Test the non-zero operand for negative sign.
|
| __ or_(ToRegister(instr->temp()), ToOperand(right));
|
| - DeoptimizeIf(sign, instr);
|
| + DeoptimizeIf(sign, instr, "minus zero");
|
| }
|
| __ bind(&done);
|
| }
|
| @@ -1624,7 +1624,7 @@ void LCodeGen::DoShiftI(LShiftI* instr) {
|
| __ shr_cl(ToRegister(left));
|
| if (instr->can_deopt()) {
|
| __ test(ToRegister(left), ToRegister(left));
|
| - DeoptimizeIf(sign, instr);
|
| + DeoptimizeIf(sign, instr, "negative value");
|
| }
|
| break;
|
| case Token::SHL:
|
| @@ -1641,7 +1641,7 @@ void LCodeGen::DoShiftI(LShiftI* instr) {
|
| case Token::ROR:
|
| if (shift_count == 0 && instr->can_deopt()) {
|
| __ test(ToRegister(left), ToRegister(left));
|
| - DeoptimizeIf(sign, instr);
|
| + DeoptimizeIf(sign, instr, "negative value");
|
| } else {
|
| __ ror(ToRegister(left), shift_count);
|
| }
|
| @@ -1656,7 +1656,7 @@ void LCodeGen::DoShiftI(LShiftI* instr) {
|
| __ shr(ToRegister(left), shift_count);
|
| } else if (instr->can_deopt()) {
|
| __ test(ToRegister(left), ToRegister(left));
|
| - DeoptimizeIf(sign, instr);
|
| + DeoptimizeIf(sign, instr, "negative value");
|
| }
|
| break;
|
| case Token::SHL:
|
| @@ -1667,7 +1667,7 @@ void LCodeGen::DoShiftI(LShiftI* instr) {
|
| __ shl(ToRegister(left), shift_count - 1);
|
| }
|
| __ SmiTag(ToRegister(left));
|
| - DeoptimizeIf(overflow, instr);
|
| + DeoptimizeIf(overflow, instr, "overflow");
|
| } else {
|
| __ shl(ToRegister(left), shift_count);
|
| }
|
| @@ -1693,7 +1693,7 @@ void LCodeGen::DoSubI(LSubI* instr) {
|
| __ sub(ToRegister(left), ToOperand(right));
|
| }
|
| if (instr->hydrogen()->CheckFlag(HValue::kCanOverflow)) {
|
| - DeoptimizeIf(overflow, instr);
|
| + DeoptimizeIf(overflow, instr, "overflow");
|
| }
|
| }
|
|
|
| @@ -1777,9 +1777,9 @@ void LCodeGen::DoDateField(LDateField* instr) {
|
| DCHECK(object.is(eax));
|
|
|
| __ test(object, Immediate(kSmiTagMask));
|
| - DeoptimizeIf(zero, instr);
|
| + DeoptimizeIf(zero, instr, "Smi");
|
| __ CmpObjectType(object, JS_DATE_TYPE, scratch);
|
| - DeoptimizeIf(not_equal, instr);
|
| + DeoptimizeIf(not_equal, instr, "not a date object");
|
|
|
| if (index->value() == 0) {
|
| __ mov(result, FieldOperand(object, JSDate::kValueOffset));
|
| @@ -1909,7 +1909,7 @@ void LCodeGen::DoAddI(LAddI* instr) {
|
| __ add(ToRegister(left), ToOperand(right));
|
| }
|
| if (instr->hydrogen()->CheckFlag(HValue::kCanOverflow)) {
|
| - DeoptimizeIf(overflow, instr);
|
| + DeoptimizeIf(overflow, instr, "overflow");
|
| }
|
| }
|
| }
|
| @@ -2133,7 +2133,7 @@ void LCodeGen::DoBranch(LBranch* instr) {
|
| } else if (expected.NeedsMap()) {
|
| // If we need a map later and have a Smi -> deopt.
|
| __ test(reg, Immediate(kSmiTagMask));
|
| - DeoptimizeIf(zero, instr);
|
| + DeoptimizeIf(zero, instr, "Smi");
|
| }
|
|
|
| Register map = no_reg; // Keep the compiler happy.
|
| @@ -2190,7 +2190,7 @@ void LCodeGen::DoBranch(LBranch* instr) {
|
| if (!expected.IsGeneric()) {
|
| // We've seen something for the first time -> deopt.
|
| // This can only happen if we are not generic already.
|
| - DeoptimizeIf(no_condition, instr);
|
| + DeoptimizeIf(no_condition, instr, "unexpected object");
|
| }
|
| }
|
| }
|
| @@ -2820,7 +2820,7 @@ void LCodeGen::DoLoadGlobalCell(LLoadGlobalCell* instr) {
|
| __ mov(result, Operand::ForCell(instr->hydrogen()->cell().handle()));
|
| if (instr->hydrogen()->RequiresHoleCheck()) {
|
| __ cmp(result, factory()->the_hole_value());
|
| - DeoptimizeIf(equal, instr);
|
| + DeoptimizeIf(equal, instr, "hole");
|
| }
|
| }
|
|
|
| @@ -2864,7 +2864,7 @@ void LCodeGen::DoStoreGlobalCell(LStoreGlobalCell* instr) {
|
| // it as no longer deleted. We deoptimize in that case.
|
| if (instr->hydrogen()->RequiresHoleCheck()) {
|
| __ cmp(Operand::ForCell(cell_handle), factory()->the_hole_value());
|
| - DeoptimizeIf(equal, instr);
|
| + DeoptimizeIf(equal, instr, "hole");
|
| }
|
|
|
| // Store the value.
|
| @@ -2881,7 +2881,7 @@ void LCodeGen::DoLoadContextSlot(LLoadContextSlot* instr) {
|
| if (instr->hydrogen()->RequiresHoleCheck()) {
|
| __ cmp(result, factory()->the_hole_value());
|
| if (instr->hydrogen()->DeoptimizesOnHole()) {
|
| - DeoptimizeIf(equal, instr);
|
| + DeoptimizeIf(equal, instr, "hole");
|
| } else {
|
| Label is_not_hole;
|
| __ j(not_equal, &is_not_hole, Label::kNear);
|
| @@ -2902,7 +2902,7 @@ void LCodeGen::DoStoreContextSlot(LStoreContextSlot* instr) {
|
| if (instr->hydrogen()->RequiresHoleCheck()) {
|
| __ cmp(target, factory()->the_hole_value());
|
| if (instr->hydrogen()->DeoptimizesOnHole()) {
|
| - DeoptimizeIf(equal, instr);
|
| + DeoptimizeIf(equal, instr, "hole");
|
| } else {
|
| __ j(not_equal, &skip_assignment, Label::kNear);
|
| }
|
| @@ -3001,7 +3001,7 @@ void LCodeGen::DoLoadFunctionPrototype(LLoadFunctionPrototype* instr) {
|
|
|
| // Check that the function has a prototype or an initial map.
|
| __ cmp(Operand(result), Immediate(factory()->the_hole_value()));
|
| - DeoptimizeIf(equal, instr);
|
| + DeoptimizeIf(equal, instr, "hole");
|
|
|
| // If the function does not have an initial map, we're done.
|
| Label done;
|
| @@ -3094,7 +3094,7 @@ void LCodeGen::DoLoadKeyedExternalArray(LLoadKeyed* instr) {
|
| __ mov(result, operand);
|
| if (!instr->hydrogen()->CheckFlag(HInstruction::kUint32)) {
|
| __ test(result, Operand(result));
|
| - DeoptimizeIf(negative, instr);
|
| + DeoptimizeIf(negative, instr, "negative value");
|
| }
|
| break;
|
| case EXTERNAL_FLOAT32_ELEMENTS:
|
| @@ -3124,7 +3124,7 @@ void LCodeGen::DoLoadKeyedFixedDoubleArray(LLoadKeyed* instr) {
|
| FAST_DOUBLE_ELEMENTS,
|
| instr->base_offset() + sizeof(kHoleNanLower32));
|
| __ cmp(hole_check_operand, Immediate(kHoleNanUpper32));
|
| - DeoptimizeIf(equal, instr);
|
| + DeoptimizeIf(equal, instr, "hole");
|
| }
|
|
|
| Operand double_load_operand = BuildFastArrayOperand(
|
| @@ -3151,10 +3151,10 @@ void LCodeGen::DoLoadKeyedFixedArray(LLoadKeyed* instr) {
|
| if (instr->hydrogen()->RequiresHoleCheck()) {
|
| if (IsFastSmiElementsKind(instr->hydrogen()->elements_kind())) {
|
| __ test(result, Immediate(kSmiTagMask));
|
| - DeoptimizeIf(not_equal, instr);
|
| + DeoptimizeIf(not_equal, instr, "not a Smi");
|
| } else {
|
| __ cmp(result, factory()->the_hole_value());
|
| - DeoptimizeIf(equal, instr);
|
| + DeoptimizeIf(equal, instr, "hole");
|
| }
|
| }
|
| }
|
| @@ -3301,9 +3301,9 @@ void LCodeGen::DoWrapReceiver(LWrapReceiver* instr) {
|
|
|
| // The receiver should be a JS object.
|
| __ test(receiver, Immediate(kSmiTagMask));
|
| - DeoptimizeIf(equal, instr);
|
| + DeoptimizeIf(equal, instr, "Smi");
|
| __ CmpObjectType(receiver, FIRST_SPEC_OBJECT_TYPE, scratch);
|
| - DeoptimizeIf(below, instr);
|
| + DeoptimizeIf(below, instr, "not a JavaScript object");
|
|
|
| __ jmp(&receiver_ok, Label::kNear);
|
| __ bind(&global_object);
|
| @@ -3329,7 +3329,7 @@ void LCodeGen::DoApplyArguments(LApplyArguments* instr) {
|
| // adaptor frame below it.
|
| const uint32_t kArgumentsLimit = 1 * KB;
|
| __ cmp(length, kArgumentsLimit);
|
| - DeoptimizeIf(above, instr);
|
| + DeoptimizeIf(above, instr, "too many arguments");
|
|
|
| __ push(receiver);
|
| __ mov(receiver, length);
|
| @@ -3522,7 +3522,7 @@ void LCodeGen::DoDeferredMathAbsTaggedHeapNumber(LMathAbs* instr) {
|
| Register input_reg = ToRegister(instr->value());
|
| __ cmp(FieldOperand(input_reg, HeapObject::kMapOffset),
|
| factory()->heap_number_map());
|
| - DeoptimizeIf(not_equal, instr);
|
| + DeoptimizeIf(not_equal, instr, "not a heap number");
|
|
|
| Label slow, allocated, done;
|
| Register tmp = input_reg.is(eax) ? ecx : eax;
|
| @@ -3569,7 +3569,7 @@ void LCodeGen::EmitIntegerMathAbs(LMathAbs* instr) {
|
| Label is_positive;
|
| __ j(not_sign, &is_positive, Label::kNear);
|
| __ neg(input_reg); // Sets flags.
|
| - DeoptimizeIf(negative, instr);
|
| + DeoptimizeIf(negative, instr, "overflow");
|
| __ bind(&is_positive);
|
| }
|
|
|
| @@ -3627,20 +3627,20 @@ void LCodeGen::DoMathFloor(LMathFloor* instr) {
|
| __ j(not_equal, &non_zero, Label::kNear);
|
| __ movmskpd(output_reg, input_reg);
|
| __ test(output_reg, Immediate(1));
|
| - DeoptimizeIf(not_zero, instr);
|
| + DeoptimizeIf(not_zero, instr, "minus zero");
|
| __ bind(&non_zero);
|
| }
|
| __ roundsd(xmm_scratch, input_reg, Assembler::kRoundDown);
|
| __ cvttsd2si(output_reg, Operand(xmm_scratch));
|
| // Overflow is signalled with minint.
|
| __ cmp(output_reg, 0x1);
|
| - DeoptimizeIf(overflow, instr);
|
| + DeoptimizeIf(overflow, instr, "overflow");
|
| } else {
|
| Label negative_sign, done;
|
| // Deoptimize on unordered.
|
| __ xorps(xmm_scratch, xmm_scratch); // Zero the register.
|
| __ ucomisd(input_reg, xmm_scratch);
|
| - DeoptimizeIf(parity_even, instr);
|
| + DeoptimizeIf(parity_even, instr, "NaN");
|
| __ j(below, &negative_sign, Label::kNear);
|
|
|
| if (instr->hydrogen()->CheckFlag(HValue::kBailoutOnMinusZero)) {
|
| @@ -3649,7 +3649,7 @@ void LCodeGen::DoMathFloor(LMathFloor* instr) {
|
| __ j(above, &positive_sign, Label::kNear);
|
| __ movmskpd(output_reg, input_reg);
|
| __ test(output_reg, Immediate(1));
|
| - DeoptimizeIf(not_zero, instr);
|
| + DeoptimizeIf(not_zero, instr, "minus zero");
|
| __ Move(output_reg, Immediate(0));
|
| __ jmp(&done, Label::kNear);
|
| __ bind(&positive_sign);
|
| @@ -3659,7 +3659,7 @@ void LCodeGen::DoMathFloor(LMathFloor* instr) {
|
| __ cvttsd2si(output_reg, Operand(input_reg));
|
| // Overflow is signalled with minint.
|
| __ cmp(output_reg, 0x1);
|
| - DeoptimizeIf(overflow, instr);
|
| + DeoptimizeIf(overflow, instr, "overflow");
|
| __ jmp(&done, Label::kNear);
|
|
|
| // Non-zero negative reaches here.
|
| @@ -3670,7 +3670,7 @@ void LCodeGen::DoMathFloor(LMathFloor* instr) {
|
| __ ucomisd(input_reg, xmm_scratch);
|
| __ j(equal, &done, Label::kNear);
|
| __ sub(output_reg, Immediate(1));
|
| - DeoptimizeIf(overflow, instr);
|
| + DeoptimizeIf(overflow, instr, "overflow");
|
|
|
| __ bind(&done);
|
| }
|
| @@ -3698,7 +3698,7 @@ void LCodeGen::DoMathRound(LMathRound* instr) {
|
| __ cvttsd2si(output_reg, Operand(xmm_scratch));
|
| // Overflow is signalled with minint.
|
| __ cmp(output_reg, 0x1);
|
| - DeoptimizeIf(overflow, instr, "conversion overflow");
|
| + DeoptimizeIf(overflow, instr, "overflow");
|
| __ jmp(&done, dist);
|
|
|
| __ bind(&below_one_half);
|
| @@ -3713,7 +3713,7 @@ void LCodeGen::DoMathRound(LMathRound* instr) {
|
| __ cvttsd2si(output_reg, Operand(input_temp));
|
| // Catch minint due to overflow, and to prevent overflow when compensating.
|
| __ cmp(output_reg, 0x1);
|
| - DeoptimizeIf(overflow, instr, "conversion overflow");
|
| + DeoptimizeIf(overflow, instr, "overflow");
|
|
|
| __ Cvtsi2sd(xmm_scratch, output_reg);
|
| __ ucomisd(xmm_scratch, input_temp);
|
| @@ -3805,7 +3805,7 @@ void LCodeGen::DoPower(LPower* instr) {
|
| __ JumpIfSmi(tagged_exponent, &no_deopt);
|
| DCHECK(!ecx.is(tagged_exponent));
|
| __ CmpObjectType(tagged_exponent, HEAP_NUMBER_TYPE, ecx);
|
| - DeoptimizeIf(not_equal, instr);
|
| + DeoptimizeIf(not_equal, instr, "not a heap number");
|
| __ bind(&no_deopt);
|
| MathPowStub stub(isolate(), MathPowStub::TAGGED);
|
| __ CallStub(&stub);
|
| @@ -4117,7 +4117,7 @@ void LCodeGen::DoBoundsCheck(LBoundsCheck* instr) {
|
| __ int3();
|
| __ bind(&done);
|
| } else {
|
| - DeoptimizeIf(cc, instr);
|
| + DeoptimizeIf(cc, instr, "out of bounds");
|
| }
|
| }
|
|
|
| @@ -4285,7 +4285,7 @@ void LCodeGen::DoTrapAllocationMemento(LTrapAllocationMemento* instr) {
|
| Register temp = ToRegister(instr->temp());
|
| Label no_memento_found;
|
| __ TestJSArrayForAllocationMemento(object, temp, &no_memento_found);
|
| - DeoptimizeIf(equal, instr);
|
| + DeoptimizeIf(equal, instr, "memento found");
|
| __ bind(&no_memento_found);
|
| }
|
|
|
| @@ -4630,12 +4630,12 @@ void LCodeGen::DoSmiTag(LSmiTag* instr) {
|
| if (hchange->CheckFlag(HValue::kCanOverflow) &&
|
| hchange->value()->CheckFlag(HValue::kUint32)) {
|
| __ test(input, Immediate(0xc0000000));
|
| - DeoptimizeIf(not_zero, instr);
|
| + DeoptimizeIf(not_zero, instr, "overflow");
|
| }
|
| __ SmiTag(input);
|
| if (hchange->CheckFlag(HValue::kCanOverflow) &&
|
| !hchange->value()->CheckFlag(HValue::kUint32)) {
|
| - DeoptimizeIf(overflow, instr);
|
| + DeoptimizeIf(overflow, instr, "overflow");
|
| }
|
| }
|
|
|
| @@ -4646,7 +4646,7 @@ void LCodeGen::DoSmiUntag(LSmiUntag* instr) {
|
| DCHECK(input->IsRegister() && input->Equals(instr->result()));
|
| if (instr->needs_check()) {
|
| __ test(result, Immediate(kSmiTagMask));
|
| - DeoptimizeIf(not_zero, instr);
|
| + DeoptimizeIf(not_zero, instr, "not a Smi");
|
| } else {
|
| __ AssertSmi(result);
|
| }
|
| @@ -4673,7 +4673,7 @@ void LCodeGen::EmitNumberUntagD(LNumberUntagD* instr, Register input_reg,
|
| if (can_convert_undefined_to_nan) {
|
| __ j(not_equal, &convert, Label::kNear);
|
| } else {
|
| - DeoptimizeIf(not_equal, instr);
|
| + DeoptimizeIf(not_equal, instr, "not a heap number");
|
| }
|
|
|
| // Heap number to XMM conversion.
|
| @@ -4686,7 +4686,7 @@ void LCodeGen::EmitNumberUntagD(LNumberUntagD* instr, Register input_reg,
|
| __ j(not_zero, &done, Label::kNear);
|
| __ movmskpd(temp_reg, result_reg);
|
| __ test_b(temp_reg, 1);
|
| - DeoptimizeIf(not_zero, instr);
|
| + DeoptimizeIf(not_zero, instr, "minus zero");
|
| }
|
| __ jmp(&done, Label::kNear);
|
|
|
| @@ -4695,7 +4695,7 @@ void LCodeGen::EmitNumberUntagD(LNumberUntagD* instr, Register input_reg,
|
|
|
| // Convert undefined (and hole) to NaN.
|
| __ cmp(input_reg, factory()->undefined_value());
|
| - DeoptimizeIf(not_equal, instr);
|
| + DeoptimizeIf(not_equal, instr, "not a heap number/undefined");
|
|
|
| ExternalReference nan =
|
| ExternalReference::address_of_canonical_non_hole_nan();
|
| @@ -4749,7 +4749,7 @@ void LCodeGen::DoDeferredTaggedToI(LTaggedToI* instr, Label* done) {
|
|
|
| __ bind(&check_false);
|
| __ cmp(input_reg, factory()->false_value());
|
| - DeoptimizeIf(not_equal, instr, "cannot truncate");
|
| + DeoptimizeIf(not_equal, instr, "not a heap number/undefined/true/false");
|
| __ Move(input_reg, Immediate(0));
|
| } else {
|
| XMMRegister scratch = ToDoubleRegister(instr->temp());
|
| @@ -4840,14 +4840,20 @@ void LCodeGen::DoDoubleToI(LDoubleToI* instr) {
|
| XMMRegister input_reg = ToDoubleRegister(input);
|
| __ TruncateDoubleToI(result_reg, input_reg);
|
| } else {
|
| - Label bailout, done;
|
| + Label lost_precision, is_nan, minus_zero, done;
|
| XMMRegister input_reg = ToDoubleRegister(input);
|
| XMMRegister xmm_scratch = double_scratch0();
|
| - __ DoubleToI(result_reg, input_reg, xmm_scratch,
|
| - instr->hydrogen()->GetMinusZeroMode(), &bailout, Label::kNear);
|
| + __ DoubleToI(result_reg, input_reg, xmm_scratch,
|
| + instr->hydrogen()->GetMinusZeroMode(), &lost_precision,
|
| + &is_nan, &minus_zero,
|
| + DeoptEveryNTimes() ? Label::kFar : Label::kNear);
|
| __ jmp(&done, Label::kNear);
|
| - __ bind(&bailout);
|
| - DeoptimizeIf(no_condition, instr);
|
| + __ bind(&lost_precision);
|
| + DeoptimizeIf(no_condition, instr, "lost precision");
|
| + __ bind(&is_nan);
|
| + DeoptimizeIf(no_condition, instr, "NaN");
|
| + __ bind(&minus_zero);
|
| + DeoptimizeIf(no_condition, instr, "minus zero");
|
| __ bind(&done);
|
| }
|
| }
|
| @@ -4860,25 +4866,29 @@ void LCodeGen::DoDoubleToSmi(LDoubleToSmi* instr) {
|
| DCHECK(result->IsRegister());
|
| Register result_reg = ToRegister(result);
|
|
|
| - Label bailout, done;
|
| + Label lost_precision, is_nan, minus_zero, done;
|
| XMMRegister input_reg = ToDoubleRegister(input);
|
| XMMRegister xmm_scratch = double_scratch0();
|
| __ DoubleToI(result_reg, input_reg, xmm_scratch,
|
| - instr->hydrogen()->GetMinusZeroMode(), &bailout, Label::kNear);
|
| + instr->hydrogen()->GetMinusZeroMode(), &lost_precision, &is_nan,
|
| + &minus_zero, DeoptEveryNTimes() ? Label::kFar : Label::kNear);
|
| __ jmp(&done, Label::kNear);
|
| - __ bind(&bailout);
|
| - DeoptimizeIf(no_condition, instr);
|
| + __ bind(&lost_precision);
|
| + DeoptimizeIf(no_condition, instr, "lost precision");
|
| + __ bind(&is_nan);
|
| + DeoptimizeIf(no_condition, instr, "NaN");
|
| + __ bind(&minus_zero);
|
| + DeoptimizeIf(no_condition, instr, "minus zero");
|
| __ bind(&done);
|
| -
|
| __ SmiTag(result_reg);
|
| - DeoptimizeIf(overflow, instr);
|
| + DeoptimizeIf(overflow, instr, "overflow");
|
| }
|
|
|
|
|
| void LCodeGen::DoCheckSmi(LCheckSmi* instr) {
|
| LOperand* input = instr->value();
|
| __ test(ToOperand(input), Immediate(kSmiTagMask));
|
| - DeoptimizeIf(not_zero, instr);
|
| + DeoptimizeIf(not_zero, instr, "not a Smi");
|
| }
|
|
|
|
|
| @@ -4886,7 +4896,7 @@ void LCodeGen::DoCheckNonSmi(LCheckNonSmi* instr) {
|
| if (!instr->hydrogen()->value()->type().IsHeapObject()) {
|
| LOperand* input = instr->value();
|
| __ test(ToOperand(input), Immediate(kSmiTagMask));
|
| - DeoptimizeIf(zero, instr);
|
| + DeoptimizeIf(zero, instr, "Smi");
|
| }
|
| }
|
|
|
| @@ -4907,14 +4917,14 @@ void LCodeGen::DoCheckInstanceType(LCheckInstanceType* instr) {
|
|
|
| // If there is only one type in the interval check for equality.
|
| if (first == last) {
|
| - DeoptimizeIf(not_equal, instr);
|
| + DeoptimizeIf(not_equal, instr, "wrong instance type");
|
| } else {
|
| - DeoptimizeIf(below, instr);
|
| + DeoptimizeIf(below, instr, "wrong instance type");
|
| // Omit check for the last type.
|
| if (last != LAST_TYPE) {
|
| __ cmpb(FieldOperand(temp, Map::kInstanceTypeOffset),
|
| static_cast<int8_t>(last));
|
| - DeoptimizeIf(above, instr);
|
| + DeoptimizeIf(above, instr, "wrong instance type");
|
| }
|
| }
|
| } else {
|
| @@ -4925,12 +4935,12 @@ void LCodeGen::DoCheckInstanceType(LCheckInstanceType* instr) {
|
| if (base::bits::IsPowerOfTwo32(mask)) {
|
| DCHECK(tag == 0 || base::bits::IsPowerOfTwo32(tag));
|
| __ test_b(FieldOperand(temp, Map::kInstanceTypeOffset), mask);
|
| - DeoptimizeIf(tag == 0 ? not_zero : zero, instr);
|
| + DeoptimizeIf(tag == 0 ? not_zero : zero, instr, "wrong instance type");
|
| } else {
|
| __ movzx_b(temp, FieldOperand(temp, Map::kInstanceTypeOffset));
|
| __ and_(temp, mask);
|
| __ cmp(temp, tag);
|
| - DeoptimizeIf(not_equal, instr);
|
| + DeoptimizeIf(not_equal, instr, "wrong instance type");
|
| }
|
| }
|
| }
|
| @@ -4946,7 +4956,7 @@ void LCodeGen::DoCheckValue(LCheckValue* instr) {
|
| Operand operand = ToOperand(instr->value());
|
| __ cmp(operand, object);
|
| }
|
| - DeoptimizeIf(not_equal, instr);
|
| + DeoptimizeIf(not_equal, instr, "value mismatch");
|
| }
|
|
|
|
|
| @@ -4961,7 +4971,7 @@ void LCodeGen::DoDeferredInstanceMigration(LCheckMaps* instr, Register object) {
|
|
|
| __ test(eax, Immediate(kSmiTagMask));
|
| }
|
| - DeoptimizeIf(zero, instr);
|
| + DeoptimizeIf(zero, instr, "instance migration failed");
|
| }
|
|
|
|
|
| @@ -5014,7 +5024,7 @@ void LCodeGen::DoCheckMaps(LCheckMaps* instr) {
|
| if (instr->hydrogen()->HasMigrationTarget()) {
|
| __ j(not_equal, deferred->entry());
|
| } else {
|
| - DeoptimizeIf(not_equal, instr);
|
| + DeoptimizeIf(not_equal, instr, "wrong map");
|
| }
|
|
|
| __ bind(&success);
|
| @@ -5053,7 +5063,7 @@ void LCodeGen::DoClampTToUint8(LClampTToUint8* instr) {
|
| // Check for undefined. Undefined is converted to zero for clamping
|
| // conversions.
|
| __ cmp(input_reg, factory()->undefined_value());
|
| - DeoptimizeIf(not_equal, instr);
|
| + DeoptimizeIf(not_equal, instr, "not a heap number/undefined");
|
| __ mov(input_reg, 0);
|
| __ jmp(&done, Label::kNear);
|
|
|
| @@ -5543,17 +5553,17 @@ void LCodeGen::DoOsrEntry(LOsrEntry* instr) {
|
| void LCodeGen::DoForInPrepareMap(LForInPrepareMap* instr) {
|
| DCHECK(ToRegister(instr->context()).is(esi));
|
| __ cmp(eax, isolate()->factory()->undefined_value());
|
| - DeoptimizeIf(equal, instr);
|
| + DeoptimizeIf(equal, instr, "undefined");
|
|
|
| __ cmp(eax, isolate()->factory()->null_value());
|
| - DeoptimizeIf(equal, instr);
|
| + DeoptimizeIf(equal, instr, "null");
|
|
|
| __ test(eax, Immediate(kSmiTagMask));
|
| - DeoptimizeIf(zero, instr);
|
| + DeoptimizeIf(zero, instr, "Smi");
|
|
|
| STATIC_ASSERT(FIRST_JS_PROXY_TYPE == FIRST_SPEC_OBJECT_TYPE);
|
| __ CmpObjectType(eax, LAST_JS_PROXY_TYPE, ecx);
|
| - DeoptimizeIf(below_equal, instr);
|
| + DeoptimizeIf(below_equal, instr, "wrong instance type");
|
|
|
| Label use_cache, call_runtime;
|
| __ CheckEnumCache(&call_runtime);
|
| @@ -5568,7 +5578,7 @@ void LCodeGen::DoForInPrepareMap(LForInPrepareMap* instr) {
|
|
|
| __ cmp(FieldOperand(eax, HeapObject::kMapOffset),
|
| isolate()->factory()->meta_map());
|
| - DeoptimizeIf(not_equal, instr);
|
| + DeoptimizeIf(not_equal, instr, "wrong map");
|
| __ bind(&use_cache);
|
| }
|
|
|
| @@ -5591,7 +5601,7 @@ void LCodeGen::DoForInCacheArray(LForInCacheArray* instr) {
|
| FieldOperand(result, FixedArray::SizeFor(instr->idx())));
|
| __ bind(&done);
|
| __ test(result, result);
|
| - DeoptimizeIf(equal, instr);
|
| + DeoptimizeIf(equal, instr, "no cache");
|
| }
|
|
|
|
|
| @@ -5599,7 +5609,7 @@ void LCodeGen::DoCheckMapValue(LCheckMapValue* instr) {
|
| Register object = ToRegister(instr->value());
|
| __ cmp(ToRegister(instr->map()),
|
| FieldOperand(object, HeapObject::kMapOffset));
|
| - DeoptimizeIf(not_equal, instr);
|
| + DeoptimizeIf(not_equal, instr, "wrong map");
|
| }
|
|
|
|
|
|
|