history: fix focus regression when showing "Remove history" confirmation dialog.

history: fix focus regression when showing "Remove history" confirmation dialog.

Also reverses "OK" + "Cancel" buttons to match other overlays.

R=estade@chromium.org
BUG=407498
Committed: https://crrev.com/30f58ec0caae5a37bed49092e90718100b55757f
Cr-Commit-Position: refs/heads/master@{#296326}

[Dan Beam, 2014-09-23 05:17:38]

this is a minimal mergeable CL.

tests are here:
https://codereview.chromium.org/595763002/

follow up CL to reverse buttons is here:
https://codereview.chromium.org/592313002/

https://codereview.chromium.org/591353002/diff/1/chrome/browser/resources/his...
File chrome/browser/resources/history/history.js (right):

https://codereview.chromium.org/591353002/diff/1/chrome/browser/resources/his...
chrome/browser/resources/history/history.js:1978:
$('alertOverlayCancel').focus();
btw, the buttons are reversed ("Remove" is the cancel button and "Cancel" is the
ok button).

[Evan Stade, 2014-09-23 20:48:52]

https://codereview.chromium.org/591353002/diff/1/chrome/browser/resources/his...
File chrome/browser/resources/history/history.js (right):

https://codereview.chromium.org/591353002/diff/1/chrome/browser/resources/his...
chrome/browser/resources/history/history.js:1978:
$('alertOverlayCancel').focus();
On 2014/09/23 05:17:37, Dan Beam wrote:
> btw, the buttons are reversed ("Remove" is the cancel button and "Cancel" is
the
> ok button).

I don't think that this restores the previous behavior, because before you had
to press tab to get focus on the remove button.

Also, I don't think this regression is impactful enough to warrant a merge.

[Dan Beam, 2014-09-23 20:50:22]

https://codereview.chromium.org/591353002/diff/1/chrome/browser/resources/his...
File chrome/browser/resources/history/history.js (right):

https://codereview.chromium.org/591353002/diff/1/chrome/browser/resources/his...
chrome/browser/resources/history/history.js:1978:
$('alertOverlayCancel').focus();
On 2014/09/23 20:48:52, Evan Stade wrote:
> On 2014/09/23 05:17:37, Dan Beam wrote:
> > btw, the buttons are reversed ("Remove" is the cancel button and "Cancel" is
> the
> > ok button).
> 
> I don't think that this restores the previous behavior, because before you had
> to press tab to get focus on the remove button.

i think this is better than the previous behavior as it's what all settings
dialogs do

> 
> Also, I don't think this regression is impactful enough to warrant a merge.

that's fine by me

[Dan Beam, 2014-09-23 20:59:38]

https://codereview.chromium.org/591353002/diff/1/chrome/browser/resources/his...
File chrome/browser/resources/history/history.js (right):

https://codereview.chromium.org/591353002/diff/1/chrome/browser/resources/his...
chrome/browser/resources/history/history.js:1978:
$('alertOverlayCancel').focus();
On 2014/09/23 20:50:22, Dan Beam wrote:
> On 2014/09/23 20:48:52, Evan Stade wrote:
> > On 2014/09/23 05:17:37, Dan Beam wrote:
> > > btw, the buttons are reversed ("Remove" is the cancel button and "Cancel"
is
> > the
> > > ok button).
> > 
> > I don't think that this restores the previous behavior, because before you
had
> > to press tab to get focus on the remove button.
> 
> i think this is better than the previous behavior as it's what all settings
> dialogs do

we looked at this together and it's not quite the same.  fixing this dialog to:
- handle enter
- focus on first tab

> 
> > 
> > Also, I don't think this regression is impactful enough to warrant a merge.
> 
> that's fine by me

[Dan Beam, 2014-09-23 22:34:16]

ok, combined.  ptal

[Evan Stade, 2014-09-23 23:51:07]

lgtm

[Dan Beam, 2014-09-23 23:53:57]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2014-09-23 23:54:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/591353002/40001

[commit-bot: I haz the power, 2014-09-24 00:06:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-24 00:06:51]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[Dan Beam, 2014-09-24 00:32:55]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2014-09-24 00:33:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/591353002/40001

[commit-bot: I haz the power, 2014-09-24 00:37:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-24 00:37:53]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[Dan Beam, 2014-09-24 00:39:15]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2014-09-24 00:40:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/591353002/40001

[commit-bot: I haz the power, 2014-09-24 00:44:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-24 00:44:21]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[Dan Beam, 2014-09-24 01:29:48]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2014-09-24 01:31:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/591353002/40001

[commit-bot: I haz the power, 2014-09-24 01:46:10]

Committed patchset #3 (id:40001) as 3f1c0911b903bc82b0c936ff1bd6b6e203ec4cd7

[commit-bot: I haz the power, 2014-09-24 01:46:46]

Patchset 3 (id:??) landed as
https://crrev.com/30f58ec0caae5a37bed49092e90718100b55757f
Cr-Commit-Position: refs/heads/master@{#296326}