ui/webui/resources/js/cr/ui/overlay.js - Issue 591353002: history: fix focus regression when showing "Remove history" confirmation dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/js/cr/ui/overlay.js

Issue 591353002: history: fix focus regression when showing "Remove history" confirmation dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/webui/resources/js/cr/ui/overlay.js

diff --git a/ui/webui/resources/js/cr/ui/overlay.js b/ui/webui/resources/js/cr/ui/overlay.js

index 67be7598ff759bb64642bc56a2c64dec0182c6c0..b829a99599c4ea38a73312dca2d750edf2f4221c 100644

--- a/ui/webui/resources/js/cr/ui/overlay.js

+++ b/ui/webui/resources/js/cr/ui/overlay.js

@@ -49,7 +49,7 @@ cr.define('cr.ui.overlay', function() {

return;

// Close the overlay on escape.

- if (e.keyCode == 27) // Escape

+ if (e.keyIdentifier == 'U+001B')

cr.dispatchSimpleEvent(overlay, 'cancelOverlay');

// Execute the overlay's default button on enter, unless focus is on an

« no previous file with comments | « chrome/test/data/webui/history_browsertest.js ('k') | no next file » | no next file with comments »