Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 591313006: Revert of [DevTools] Implement DevToolsManager::Observer which notifies about target updates. (Closed)

Created:
6 years, 2 months ago by dgozman
Modified:
6 years, 2 months ago
Reviewers:
vkuzkokov, jam, pfeldman
CC:
chromium-reviews, vsevik, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@move-enumerate-to-dtm-delegate
Project:
chromium
Visibility:
Public.

Description

Revert of [DevTools] Implement DevToolsManager::Observer which notifies about target updates. (patchset #5 id:80001 of https://codereview.chromium.org/577923002/) Reason for revert: Breaks asan bot. http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/7924 Original issue's description: > [DevTools] Implement DevToolsManager::Observer which notifies about target updates. > > BUG=398049 > > Committed: https://crrev.com/509c17cf55a12b49b017245f6d0cff558f312637 > Cr-Commit-Position: refs/heads/master@{#296921} TBR=pfeldman@chromium.org,vkuzkokov@chromium.org,jam@chromium.org NOTREECHECKS=true NOTRY=true BUG=398049 Committed: https://crrev.com/24ce55da5ac28d3e63cc4427c3d9d71b004c6fbd Cr-Commit-Position: refs/heads/master@{#296944}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -368 lines) Patch
M content/browser/devtools/devtools_agent_host_impl.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M content/browser/devtools/devtools_manager.h View 2 chunks +5 lines, -38 lines 0 comments Download
M content/browser/devtools/devtools_manager.cc View 2 chunks +20 lines, -94 lines 0 comments Download
M content/browser/devtools/devtools_manager_unittest.cc View 3 chunks +1 line, -207 lines 0 comments Download
M content/browser/devtools/embedded_worker_devtools_manager.cc View 5 chunks +1 line, -7 lines 0 comments Download
M content/browser/devtools/render_view_devtools_agent_host.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/devtools/render_view_devtools_agent_host.cc View 3 chunks +0 lines, -12 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dgozman
Created Revert of [DevTools] Implement DevToolsManager::Observer which notifies about target updates.
6 years, 2 months ago (2014-09-26 15:24:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/591313006/1
6 years, 2 months ago (2014-09-26 15:24:58 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as dc78cf8007cadf247a9cc9c36aab85f8508a2936
6 years, 2 months ago (2014-09-26 15:25:39 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 15:26:14 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/24ce55da5ac28d3e63cc4427c3d9d71b004c6fbd
Cr-Commit-Position: refs/heads/master@{#296944}

Powered by Google App Engine
This is Rietveld 408576698