content/browser/web_contents/web_contents_impl.cc - Issue 591313006: Revert of [DevTools] Implement DevToolsManager::Observer which notifies about target updates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 591313006: Revert of [DevTools] Implement DevToolsManager::Observer which notifies about target updates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move-enumerate-to-dtm-delegate

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index e5529cd6b8b467e716caeca54d50f5858502a53b..b6ff8109294e6b8da9454c4cee3f9241cf83a6e8 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -23,7 +23,7 @@

#include "content/browser/browser_plugin/browser_plugin_embedder.h"

#include "content/browser/browser_plugin/browser_plugin_guest.h"

#include "content/browser/child_process_security_policy_impl.h"

-#include "content/browser/devtools/devtools_manager.h"

+#include "content/browser/devtools/render_view_devtools_agent_host.h"

#include "content/browser/dom_storage/dom_storage_context_wrapper.h"

#include "content/browser/dom_storage/session_storage_namespace_impl.h"

#include "content/browser/download/download_stats.h"

@@ -3559,8 +3559,6 @@

FOR_EACH_OBSERVER(

WebContentsObserver, observers_, RenderFrameCreated(main_frame));

SetAccessibilityModeOnFrame(accessibility_mode_, main_frame);

- DevToolsManager::GetInstance()->RenderViewCreated(this, render_view_host);

}

void WebContentsImpl::RenderViewReady(RenderViewHost* rvh) {

« no previous file with comments | « content/browser/devtools/render_view_devtools_agent_host.cc ('k') | no next file » | no next file with comments »