Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 591233002: [exp] Browser-side fling in aura.

Created:
6 years, 3 months ago by sadrul
Modified:
6 years, 3 months ago
Reviewers:
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, jdduke+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@fling-curve-config-remove
Project:
chromium
Visibility:
Public.

Description

[exp] Browser-side fling in aura. When a FlingStart event comes in, start generating a sequence of ScrollUpdate events, and send those to the renderer instead of the FlingStart event. This moves the control of the fling scroll entirely in the browser process. Some details about how this works: . The replacement of FlingStart event with a sequence of ScrollUpdate happens at RenderWidgetHostViewAura in this version. It should move somewhere platform neutral, ideally in InputRouterImpl. . The ScrollUpdate events are generated from a CompositorAnimationObserver callback, i.e. a ScrollUpdate[WithoutPropagation] event is generated for every animation-tick in the compositor (i.e. every frame?). Ideally, we would generate the ScrollUpdate[WithoutPropagation] event in response to the ScrollUpdate ack from the renderer instead. . The location of all the ScrollUpdate[WithoutPropagation] events are the same as the location of the FlingStart event. . Any in-progress fling is stopped when a GESTURE_BEGIN event is received (i.e. a new touch-point becomes active). If the mechanisms are moved into InputRouterImpl, this should happen upon receiving a FlingCancel event instead. BUG=TBD

Patch Set 1 #

Patch Set 2 : self-nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -9 lines) Patch
M content/browser/renderer_host/input/gesture_event_queue.cc View 2 chunks +9 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 4 chunks +99 lines, -1 line 0 comments Download
M content/common/input/web_input_event_traits.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M content/renderer/input/input_handler_proxy.cc View 4 chunks +9 lines, -2 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698