Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 591203003: media: Pass DemuxerStreamProvider in Renderer::Initialize(). (Closed)

Created:
6 years, 3 months ago by xhwang
Modified:
6 years, 2 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, Aaron Boodman, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

media: Pass DemuxerStreamProvider in Renderer::Initialize(). Currently DemuxerStreamProvider is passed in the constructor of Renderer implementations (e.g. RendererImpl and MojoRendererImpl). However, if we want to create the Renderer earlier and pass it to WebMediaPlayerImpl or Pipeline, the DemuxerStreamProvider may not be available yet. Meanwhile, when Renderer is initialized by the Pipeline, DemuxerStreamProvider is always available. This CL moves the DemuxerStreamProvider parameter to Renderer::Initialize() to accommodate the above cases. BUG=416570 TEST=Unit tests updated. Committed: https://crrev.com/abd95fd44fb0b36b06fa3a84f39472cff4d6386a Cr-Commit-Position: refs/heads/master@{#298006}

Patch Set 1 #

Patch Set 2 : fix mojo test #

Patch Set 3 : rebase only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -46 lines) Patch
M media/base/mock_filters.h View 1 chunk +2 lines, -1 line 0 comments Download
M media/base/pipeline.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M media/base/pipeline_unittest.cc View 2 chunks +11 lines, -11 lines 0 comments Download
M media/base/renderer.h View 2 chunks +7 lines, -3 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 1 2 1 chunk +1 line, -4 lines 0 comments Download
M media/filters/pipeline_integration_test_base.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/filters/renderer_impl.h View 1 chunk +6 lines, -6 lines 0 comments Download
M media/filters/renderer_impl.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M media/filters/renderer_impl_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M media/mojo/services/mojo_renderer_impl.h View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M media/mojo/services/mojo_renderer_impl.cc View 2 chunks +10 lines, -7 lines 0 comments Download
M media/mojo/services/renderer_unittest.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M media/tools/player_x11/player_x11.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
xhwang
PTAL
6 years, 3 months ago (2014-09-22 23:50:40 UTC) #2
scherkus (not reviewing)
lgtm OOC, which Renderer implementations do we create early?
6 years, 3 months ago (2014-09-23 00:55:12 UTC) #3
xhwang
rebase only
6 years, 2 months ago (2014-10-03 05:41:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/591203003/40001
6 years, 2 months ago (2014-10-03 05:42:46 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001) as dccea6433a38c1e8181307fdfb26ce049a4213b5
6 years, 2 months ago (2014-10-03 07:10:08 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-03 07:10:41 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/abd95fd44fb0b36b06fa3a84f39472cff4d6386a
Cr-Commit-Position: refs/heads/master@{#298006}

Powered by Google App Engine
This is Rietveld 408576698