Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: media/base/renderer.h

Issue 591203003: media: Pass DemuxerStreamProvider in Renderer::Initialize(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase only Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/pipeline_unittest.cc ('k') | media/blink/webmediaplayer_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/renderer.h
diff --git a/media/base/renderer.h b/media/base/renderer.h
index af02ba512bd1cf8e3f335fbd1b7335804df0438d..78ae043ee3042d002470a72b5e2d2d5d4cfdd89a 100644
--- a/media/base/renderer.h
+++ b/media/base/renderer.h
@@ -14,6 +14,7 @@
namespace media {
class MediaKeys;
+class DemuxerStreamProvider;
class MEDIA_EXPORT Renderer {
public:
@@ -24,15 +25,18 @@ class MEDIA_EXPORT Renderer {
// Stops rendering and fires any pending callbacks.
virtual ~Renderer();
- // Initializes the Renderer, executing |init_cb| upon completion.
- // If initialization failed, fires |error_cb| before |init_cb|.
+ // Initializes the Renderer with |demuxer_stream_provider|, executing
+ // |init_cb| upon completion. If initialization failed, fires |error_cb|
+ // before |init_cb|. |demuxer_stream_provider| must be valid throughout the
+ // lifetime of the Renderer object.
//
// Permanent callbacks:
// - |statistics_cb|: Executed periodically with rendering statistics.
// - |time_cb|: Executed whenever time has advanced through rendering.
// - |ended_cb|: Executed when rendering has reached the end of stream.
// - |error_cb|: Executed if any error was encountered during rendering.
- virtual void Initialize(const base::Closure& init_cb,
+ virtual void Initialize(DemuxerStreamProvider* demuxer_stream_provider,
+ const base::Closure& init_cb,
const StatisticsCB& statistics_cb,
const base::Closure& ended_cb,
const PipelineStatusCB& error_cb,
« no previous file with comments | « media/base/pipeline_unittest.cc ('k') | media/blink/webmediaplayer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698