Issue 591043002: Remove enable-speech-dispatcher flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 591043002: Remove enable-speech-dispatcher flag (Closed)

Created:
6 years, 3 months ago by deejay

Modified:
6 years, 2 months ago

Reviewers:
dmazzoni

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove enable-speech-dispatcher flag "WebSpeech-synthesis" is not working that is caused by "enable-speech-dispatcher" flag in linux It is only disabled in linux. (enabled in MacOS) I think that flag don't need any more, because this feature is enabled automatically in official version of chrome. BUG=416411

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -21 lines)			Patch
M	chrome/browser/speech/tts_linux.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/startup/bad_flags_prompt.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	content/public/common/content_switches.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	content/public/common/content_switches.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

dmazzoni

6 years, 3 months ago (2014-09-23 05:44:14 UTC) #3

not lgtm

No, speech dispatcher is behind a flag on purpose. Some users prefer it, but
it's buggy and it can make Chrome hang or crash, so we can't enable it by
default.

I don't understand how removing this flag would help.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages