Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 59073010: Temporary fix for CWS client redirect issue to undo a regression. (Closed)

Created:
7 years, 1 month ago by Charlie Reis
Modified:
7 years, 1 month ago
Reviewers:
nasko
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, miu+watch_chromium.org
Visibility:
Public.

Description

Temporary fix for CWS client redirect issue to undo a regression. This re-introduces a smaller bug fixed by r231370 until the underlying problem in WebDataSource::replacesCurrentHistoryItem is resolved. BUG=313572, 311271 TEST=Try to add an app in CWS when not signed in. Go back from signin page. R=nasko@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233454

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Charlie Reis
Nasko, can you review? I hate to put the bug back in, but I think ...
7 years, 1 month ago (2013-11-06 23:01:42 UTC) #1
nasko
Urgh, ugly, but oh well. LGTM
7 years, 1 month ago (2013-11-06 23:06:56 UTC) #2
Charlie Reis
7 years, 1 month ago (2013-11-07 01:03:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r233454 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698