Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 59073010: Temporary fix for CWS client redirect issue to undo a regression. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 340f8a4bd6a1155acf9eccec38c6667b701d909e..5ed64646098fdc552511f8f9a1175749757e4a28 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -3150,6 +3150,13 @@ void WebContentsImpl::RequestTransferURL(
// Navigations in Web UI pages count as browser-initiated navigations.
params.is_renderer_initiated = false;
+
+ // TODO(creis): Remove this line. In the short term, it fixes a regression
+ // (http://crbug.com/313572) by partially reverting r231370.
+ // The underlying problem is that WebDataSource::replacesCurrentHistoryItem
+ // should be returning false when the CWS goes to the sign-in page.
+ // See http://crbug.com/311721.
+ params.should_replace_current_entry = false;
}
new_contents = OpenURL(params);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698