Add support for icons.{src,type,density} in Manifest.

content/public/common/manifest.cc

Index: content/public/common/manifest.cc
diff --git a/content/public/common/manifest.cc b/content/public/common/manifest.cc
index 9aeedd419193f20e40313c5e797ac44d83c181da..71b2cd2b128daf17309e632481fb9c88d9764c03 100644
--- a/content/public/common/manifest.cc
+++ b/content/public/common/manifest.cc
@@ -6,8 +6,16 @@
 
 namespace content {
 
+const double Manifest::Icon::kDefaultDensity = 1;

[palmer, 2014/09/22 20:35:43]

IMO, this makes more sense in the header file.

[mlamouri (slow - plz ping), 2014/09/22 21:09:31]

I can't define it in the header. I get a static-float-init warning and requires
constexpr to fix that which is C++11.

 const size_t Manifest::kMaxIPCStringLength = 4 * 1024;
 
+Manifest::Icon::Icon()
+    : density(kDefaultDensity) {
+}
+
+Manifest::Icon::~Icon() {
+}
+
 Manifest::Manifest()
     : display(DISPLAY_MODE_UNSPECIFIED),
       orientation(blink::WebScreenOrientationLockDefault) {
@@ -21,7 +29,8 @@ bool Manifest::IsEmpty() const {
          short_name.is_null() &&
          start_url.is_empty() &&
          display == DISPLAY_MODE_UNSPECIFIED &&
-         orientation == blink::WebScreenOrientationLockDefault;
+         orientation == blink::WebScreenOrientationLockDefault &&
+         icons.empty();
 }
 
 } // namespace content