Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 590333002: Replace usage of basictypes.h with a combination of stdint.h and base/macros.h. (Closed)

Created:
6 years, 3 months ago by Sorin Jianu
Modified:
6 years, 3 months ago
Reviewers:
waffles
CC:
chromium-reviews, cpu_(ooo_6.6-7.5)
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Project:
chromium
Visibility:
Public.

Description

Replace usage of basictypes.h with a combination of stdint.h and base/macros.h. Fix some style issues regarding order of includes and forward declararions. BUG=416623 Committed: https://crrev.com/5cb1f549d544e2b1bd5ee43eca5bc8b6bdc3b67e Cr-Commit-Position: refs/heads/master@{#296139}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -112 lines) Patch
M chrome/browser/component_updater/cld_component_installer.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/component_updater/cld_component_installer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/component_updater/component_patcher_operation_out_of_process.h View 2 chunks +10 lines, -4 lines 0 comments Download
M chrome/browser/component_updater/component_patcher_operation_out_of_process.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/component_updater/ev_whitelist_component_installer.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/component_updater/ev_whitelist_component_installer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/component_updater/pepper_flash_component_installer.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/component_updater/pnacl/pnacl_component_installer.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/component_updater/pnacl/pnacl_component_installer.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/component_updater/recovery_component_installer.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/component_updater/sw_reporter_installer_win.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/component_updater/swiftshader_component_installer.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/component_updater/test/cld_component_installer_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/component_updater/test/component_updater_service_unittest.h View 1 chunk +8 lines, -5 lines 0 comments Download
M chrome/browser/component_updater/test/component_updater_service_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/component_updater/widevine_cdm_component_installer.cc View 5 chunks +8 lines, -7 lines 0 comments Download
M components/component_updater/background_downloader_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/component_updater/background_downloader_win.cc View 5 chunks +14 lines, -8 lines 0 comments Download
M components/component_updater/component_patcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/component_updater/component_patcher.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/component_updater/component_patcher_operation.h View 2 chunks +4 lines, -4 lines 0 comments Download
M components/component_updater/component_patcher_operation.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M components/component_updater/component_unpacker.h View 3 chunks +4 lines, -3 lines 0 comments Download
M components/component_updater/component_unpacker.cc View 5 chunks +11 lines, -9 lines 0 comments Download
M components/component_updater/component_updater_ping_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M components/component_updater/component_updater_ping_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/component_updater/component_updater_service.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/component_updater/component_updater_service.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M components/component_updater/component_updater_utils.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/component_updater/crx_downloader.h View 3 chunks +7 lines, -6 lines 0 comments Download
M components/component_updater/crx_update_item.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/component_updater/default_component_installer.h View 2 chunks +3 lines, -1 line 0 comments Download
M components/component_updater/test/component_patcher_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/component_updater/test/request_sender_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/component_updater/test/test_configurator.h View 1 chunk +6 lines, -1 line 0 comments Download
M components/component_updater/test/update_checker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/component_updater/test/url_request_post_interceptor.h View 2 chunks +14 lines, -13 lines 0 comments Download
M components/component_updater/test/url_request_post_interceptor.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/component_updater/update_checker.h View 1 chunk +1 line, -1 line 0 comments Download
M components/component_updater/update_checker.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/component_updater/update_response.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/component_updater/url_fetcher_downloader.h View 2 chunks +7 lines, -5 lines 0 comments Download
M components/component_updater/url_fetcher_downloader.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sorin Jianu
This is mostly a mechanical change base on file and replace but there are some ...
6 years, 3 months ago (2014-09-22 21:00:19 UTC) #2
waffles
lgtm
6 years, 3 months ago (2014-09-22 21:11:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/590333002/1
6 years, 3 months ago (2014-09-23 01:45:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 4acc1def3b2ea3bf529b3dad9dbaad608ada61ee
6 years, 3 months ago (2014-09-23 04:07:54 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 04:08:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5cb1f549d544e2b1bd5ee43eca5bc8b6bdc3b67e
Cr-Commit-Position: refs/heads/master@{#296139}

Powered by Google App Engine
This is Rietveld 408576698