chrome/browser/component_updater/component_patcher_operation_out_of_process.cc - Issue 590333002: Replace usage of basictypes.h with a combination of stdint.h and base/macros.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/component_patcher_operation_out_of_process.cc

Issue 590333002: Replace usage of basictypes.h with a combination of stdint.h and base/macros.h. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/component_updater/component_patcher_operation_out_of_process.h ('k') | chrome/browser/component_updater/ev_whitelist_component_installer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/component_updater/component_patcher_operation_out_of_process.cc

diff --git a/chrome/browser/component_updater/component_patcher_operation_out_of_process.cc b/chrome/browser/component_updater/component_patcher_operation_out_of_process.cc

index 3c24c950931cda3a6806b900ee888a9c60373268..221ba263e3677f7967ed7d845189cfd178c81a2d 100644

--- a/chrome/browser/component_updater/component_patcher_operation_out_of_process.cc

+++ b/chrome/browser/component_updater/component_patcher_operation_out_of_process.cc

@@ -7,6 +7,8 @@

#include <vector>

#include "base/bind.h"

+#include "base/callback.h"

+#include "base/files/file_path.h"

#include "chrome/common/chrome_utility_messages.h"

#include "components/component_updater/component_updater_service.h"

#include "content/public/browser/browser_thread.h"

@@ -84,9 +86,9 @@ ChromeOutOfProcessPatcher::~ChromeOutOfProcessPatcher() {

void ChromeOutOfProcessPatcher::Patch(

const std::string& operation,

scoped_refptr<base::SequencedTaskRunner> task_runner,

- base::FilePath& input_abs_path,

- base::FilePath& patch_abs_path,

- base::FilePath& output_abs_path,

+ const base::FilePath& input_abs_path,

+ const base::FilePath& patch_abs_path,

+ const base::FilePath& output_abs_path,

base::Callback<void(int result)> callback) {

host_ = new PatchHost(callback, task_runner);

scoped_ptr<IPC::Message> patch_message;