Issue 590283002: uint128_struct: address misunderstood review feedback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 590283002: uint128_struct: address misunderstood review feedback (Closed)

Created:
6 years, 3 months ago by Mark Mentovai

Modified:
6 years, 3 months ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Project:
crashpad

Visibility:
Public.

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	util/numeric/int128.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download
	M	util/numeric/int128_test.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Mark Mentovai

6 years, 3 months ago (2014-09-22 21:16:09 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as fec8699 (presubmit successful).