Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Side by Side Diff: util/numeric/int128_test.cc

Issue 590283002: uint128_struct: address misunderstood review feedback (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « util/numeric/int128.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #include "util/numeric/int128.h" 15 #include "util/numeric/int128.h"
16 16
17 #include "base/basictypes.h"
18 #include "gtest/gtest.h" 17 #include "gtest/gtest.h"
19 18
20 namespace { 19 namespace {
21 20
22 using namespace crashpad; 21 using namespace crashpad;
23 22
24 TEST(Int128, UInt128) { 23 TEST(Int128, UInt128) {
25 #if defined(ARCH_CPU_LITTLE_ENDIAN) 24 #if defined(ARCH_CPU_LITTLE_ENDIAN)
26 const uint8_t kBytes[] = 25 const uint8_t kBytes[] =
27 {0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15}; 26 {0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15};
28 #else 27 #else
29 const uint8_t kBytes[] = 28 const uint8_t kBytes[] =
30 {15, 14, 13, 12, 11, 10, 9, 8, 7, 6, 5, 4, 3, 2, 1, 0}; 29 {15, 14, 13, 12, 11, 10, 9, 8, 7, 6, 5, 4, 3, 2, 1, 0};
31 #endif 30 #endif
32 31
33 uint128_struct uint128; 32 uint128_struct uint128;
34 COMPILE_ASSERT(sizeof(uint128) == sizeof(kBytes), sizes_must_be_equal); 33 COMPILE_ASSERT(sizeof(uint128) == sizeof(kBytes), sizes_must_be_equal);
35 34
36 uint128 = bit_cast<uint128_struct>(kBytes); 35 uint128 = bit_cast<uint128_struct>(kBytes);
37 36
38 EXPECT_EQ(0x0706050403020100u, uint128.lo); 37 EXPECT_EQ(0x0706050403020100u, uint128.lo);
39 EXPECT_EQ(0x0f0e0d0c0b0a0908u, uint128.hi); 38 EXPECT_EQ(0x0f0e0d0c0b0a0908u, uint128.hi);
40 } 39 }
41 40
42 } // namespace 41 } // namespace
OLDNEW
« no previous file with comments | « util/numeric/int128.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698