src/ia32/lithium-codegen-ia32.cc - Issue 59023003: Generate TypedArrayInitialize builtin in hydrogen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/lithium-codegen-ia32.cc

Issue 59023003: Generate TypedArrayInitialize builtin in hydrogen. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Rebased and updated Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/lithium-codegen-ia32.cc

diff --git a/src/ia32/lithium-codegen-ia32.cc b/src/ia32/lithium-codegen-ia32.cc

index fd70b7717bb493d50b1d19b8befe23a6ca156f82..ae38407ee83ebc0b2235b3c7a75184da1f6aee43 100644

--- a/src/ia32/lithium-codegen-ia32.cc

+++ b/src/ia32/lithium-codegen-ia32.cc

@@ -744,7 +744,7 @@ int32_t LCodeGen::ToRepresentation(LConstantOperand* op,

const Representation& r) const {

HConstant* constant = chunk_->LookupConstant(op);

int32_t value = constant->Integer32Value();

- if (r.IsInteger32()) return value;

+ if (r.IsInteger32() || r.IsExternal()) return value;

ASSERT(r.IsSmiOrTagged());

return reinterpret_cast<int32_t>(Smi::FromInt(value));

}