Chromium Code Reviews| Index: src/property-details.h |
| diff --git a/src/property-details.h b/src/property-details.h |
| index 92e4f81c01cb1e6b5f28eee3e5ce74aadd6d18a3..8f26c8b18a53923fc6279ed90ee5d83121951832 100644 |
| --- a/src/property-details.h |
| +++ b/src/property-details.h |
| @@ -131,6 +131,10 @@ class Representation { |
| } |
| bool is_more_general_than(const Representation& other) const { |
| + if (kind_ == kExternal && other.kind_ == kNone) return true; |
| + if (kind_ == kExternal && other.kind_ == kExternal) return false; |
| + if (kind_ == kNone && other.kind_ == kExternal) return false; |
|
mvstanton
2013/11/18 10:44:49
How do you know these are the only cases you'll be
Dmitry Lomov (no reviews)
2013/11/18 13:48:14
Representation is a lattice where kNone is the bot
|
| + |
| ASSERT(kind_ != kExternal); |
| ASSERT(other.kind_ != kExternal); |
| if (IsHeapObject()) return other.IsDouble() || other.IsNone(); |