Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 589703003: Cleanup: Merge several OS==win sections in chrome_exe.gypi. (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 3 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Merge several OS==win sections in chrome_exe.gypi. Committed: https://crrev.com/b32f445a4e01c57b363066653b70fa187e6dc60d Cr-Commit-Position: refs/heads/master@{#295865}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -15 lines) Patch
M chrome/chrome_exe.gypi View 4 chunks +7 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Lei Zhang
6 years, 3 months ago (2014-09-20 00:33:49 UTC) #2
scottmg
lgtm
6 years, 3 months ago (2014-09-20 02:16:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/589703003/1
6 years, 3 months ago (2014-09-20 02:19:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as c7aab57827041c4826c1c106613c7fb567965b5c
6 years, 3 months ago (2014-09-20 13:18:00 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-20 13:18:44 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b32f445a4e01c57b363066653b70fa187e6dc60d
Cr-Commit-Position: refs/heads/master@{#295865}

Powered by Google App Engine
This is Rietveld 408576698