Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6984)

Unified Diff: chrome/chrome_exe.gypi

Issue 589703003: Cleanup: Merge several OS==win sections in chrome_exe.gypi. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_exe.gypi
diff --git a/chrome/chrome_exe.gypi b/chrome/chrome_exe.gypi
index 04b76a76e477b38f6ed041eac132939ad83ee58d..93386d4b6a5aaccd5f07692bff32e076443a2271 100644
--- a/chrome/chrome_exe.gypi
+++ b/chrome/chrome_exe.gypi
@@ -98,15 +98,6 @@
}],
]
}],
- ['OS == "win"', {
- 'sources!': [
- # We still want the _win entry point for sandbox, etc.
- 'app/chrome_exe_main_aura.cc',
- ],
- 'dependencies': [
- '../ui/gfx/gfx.gyp:gfx',
- ],
- }],
['OS == "android"', {
# Don't put the 'chrome' target in 'all' on android
'suppress_wildcard': 1,
@@ -499,6 +490,9 @@
'../chrome_elf/chrome_elf.gyp:chrome_elf',
'../components/components.gyp:crash_component',
'../sandbox/sandbox.gyp:sandbox',
+ '../ui/gfx/gfx.gyp:gfx',
+ '../win8/metro_driver/metro_driver.gyp:metro_driver',
+ '../win8/delegate_execute/delegate_execute.gyp:*',
],
'sources': [
'app/chrome_crash_reporter_client.cc',
@@ -508,6 +502,10 @@
'common/crash_keys.h',
'<(SHARED_INTERMEDIATE_DIR)/chrome_version/chrome_exe_version.rc',
],
+ 'sources!': [
+ # We still want the _win entry point for sandbox, etc.
+ 'app/chrome_exe_main_aura.cc',
+ ],
'msvs_settings': {
'VCLinkerTool': {
'ImportLibrary': '$(OutDir)\\lib\\chrome_exe.lib',
@@ -578,12 +576,6 @@
['OS=="win" and component=="shared_library"', {
'defines': ['COMPILE_CONTENT_STATICALLY'],
}],
- ['OS=="win"', {
- 'dependencies': [
- '../win8/metro_driver/metro_driver.gyp:metro_driver',
- '../win8/delegate_execute/delegate_execute.gyp:*',
- ],
- }],
],
},
],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698