Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 589703002: Try to make `git cl try` match the CQ more closely (Closed)

Created:
6 years, 3 months ago by scottmg
Modified:
6 years, 3 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, dpranke, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Try to make `git cl try` match the CQ more closely Two lists ftw! R=maruel@chromium.org BUG=416120 Committed: https://crrev.com/d472406c3ed79761de308f1c809d8df325704aae Cr-Commit-Position: refs/heads/master@{#295830}

Patch Set 1 #

Patch Set 2 : maybe fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M PRESUBMIT.py View 1 4 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (6 generated)
scottmg
I'm not sure what I'm doing... but I guess I'll see if this was a ...
6 years, 3 months ago (2014-09-19 20:22:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/589703002/20001
6 years, 3 months ago (2014-09-19 21:20:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/589703002/20001
6 years, 3 months ago (2014-09-19 21:20:37 UTC) #7
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-09-19 21:20:37 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-09-19 21:20:39 UTC) #10
scottmg
Hm, apparently the CQ tries to be too smart (doesn't start its list of tryjobs) ...
6 years, 3 months ago (2014-09-19 21:25:06 UTC) #11
M-A Ruel
On 2014/09/19 21:25:06, scottmg wrote: > Hm, apparently the CQ tries to be too smart ...
6 years, 3 months ago (2014-09-20 00:17:49 UTC) #12
scottmg
On 2014/09/20 00:17:49, M-A Ruel wrote: > On 2014/09/19 21:25:06, scottmg wrote: > > Hm, ...
6 years, 3 months ago (2014-09-20 00:19:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/589703002/20001
6 years, 3 months ago (2014-09-20 00:20:50 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/589703002/20001
6 years, 3 months ago (2014-09-20 00:20:59 UTC) #16
scottmg
(I think OK now. ios_rel_device_ninja was broken at the time of `git cl try` per ...
6 years, 3 months ago (2014-09-20 00:22:36 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 6dac2d1f6419ffcda87504568f1829b8891bd90e
6 years, 3 months ago (2014-09-20 00:27:17 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 3e252bf3451550db25827606f60843f883a53c94
6 years, 3 months ago (2014-09-20 00:27:26 UTC) #19
commit-bot: I haz the power
6 years, 3 months ago (2014-09-20 00:27:50 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d472406c3ed79761de308f1c809d8df325704aae
Cr-Commit-Position: refs/heads/master@{#295830}

Powered by Google App Engine
This is Rietveld 408576698