|
|
DescriptionTry to make `git cl try` match the CQ more closely
Two lists ftw!
R=maruel@chromium.org
BUG=416120
Committed: https://crrev.com/d472406c3ed79761de308f1c809d8df325704aae
Cr-Commit-Position: refs/heads/master@{#295830}
Patch Set 1 #Patch Set 2 : maybe fix #Messages
Total messages: 20 (6 generated)
scottmg@chromium.org changed reviewers: + maruel@chromium.org
scottmg@chromium.org changed reviewers: - dpranke@chromium.org
I'm not sure what I'm doing... but I guess I'll see if this was a win when I click the CQ button.
The CQ bit was checked by scottmg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/589703002/20001
The CQ bit was unchecked by commit-bot@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/589703002/20001
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a provisional committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a provisional committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Hm, apparently the CQ tries to be too smart (doesn't start its list of tryjobs) so I can't test whether the lists match until it's lgtm'd.
On 2014/09/19 21:25:06, scottmg wrote: > Hm, apparently the CQ tries to be too smart (doesn't start its list of tryjobs) > so I can't test whether the lists match until it's lgtm'd. TBR? lgtm
On 2014/09/20 00:17:49, M-A Ruel wrote: > On 2014/09/19 21:25:06, scottmg wrote: > > Hm, apparently the CQ tries to be too smart (doesn't start its list of > tryjobs) > > so I can't test whether the lists match until it's lgtm'd. > > TBR? Meh, wasn't really a rush. > lgtm Thanks.
The CQ bit was checked by scottmg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/589703002/20001
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/589703002/20001
(I think OK now. ios_rel_device_ninja was broken at the time of `git cl try` per irc, so resubmitting that makes sense. And chromium_presubmit makes sense to wait until post-review just before commit.)
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 6dac2d1f6419ffcda87504568f1829b8891bd90e
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 3e252bf3451550db25827606f60843f883a53c94
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/d472406c3ed79761de308f1c809d8df325704aae Cr-Commit-Position: refs/heads/master@{#295830} |