Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Side by Side Diff: PRESUBMIT.py

Issue 589703002: Try to make `git cl try` match the CQ more closely (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: maybe fix Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 1464 matching lines...) Expand 10 before | Expand all | Expand 10 after
1475 1475
1476 builders_and_tests = { 1476 builders_and_tests = {
1477 # TODO(maruel): Figure out a way to run 'sizes' where people can 1477 # TODO(maruel): Figure out a way to run 'sizes' where people can
1478 # effectively update the perf expectation correctly. This requires a 1478 # effectively update the perf expectation correctly. This requires a
1479 # clobber=True build running 'sizes'. 'sizes' is not accurate with 1479 # clobber=True build running 'sizes'. 'sizes' is not accurate with
1480 # incremental build. Reference: 1480 # incremental build. Reference:
1481 # http://chromium.org/developers/tree-sheriffs/perf-sheriffs. 1481 # http://chromium.org/developers/tree-sheriffs/perf-sheriffs.
1482 # TODO(maruel): An option would be to run 'sizes' but not count a failure 1482 # TODO(maruel): An option would be to run 'sizes' but not count a failure
1483 # of this step as a try job failure. 1483 # of this step as a try job failure.
1484 'android_aosp': ['compile'], 1484 'android_aosp': ['compile'],
1485 'android_arm64_dbg_recipe': ['slave_steps'],
1486 'android_chromium_gn_compile_dbg': ['compile'],
1485 'android_chromium_gn_compile_rel': ['compile'], 1487 'android_chromium_gn_compile_rel': ['compile'],
1486 'android_clang_dbg': ['slave_steps'], 1488 'android_clang_dbg': ['slave_steps'],
1489 'android_clang_dbg_recipe': ['slave_steps'],
1487 'android_dbg_tests_recipe': ['slave_steps'], 1490 'android_dbg_tests_recipe': ['slave_steps'],
1488 'cros_x86': ['defaulttests'], 1491 'cros_x86': ['defaulttests'],
1489 'ios_dbg_simulator': [ 1492 'ios_dbg_simulator': [
1490 'compile', 1493 'compile',
1491 'base_unittests', 1494 'base_unittests',
1492 'content_unittests', 1495 'content_unittests',
1493 'crypto_unittests', 1496 'crypto_unittests',
1494 'url_unittests', 1497 'url_unittests',
1495 'net_unittests', 1498 'net_unittests',
1496 'sql_unittests', 1499 'sql_unittests',
1497 'ui_unittests', 1500 'ui_unittests',
1498 ], 1501 ],
1499 'ios_rel_device': ['compile'], 1502 'ios_rel_device': ['compile'],
1503 'ios_rel_device_ninja': ['compile'],
1500 'linux_asan': ['compile'], 1504 'linux_asan': ['compile'],
1501 'mac_asan': ['compile'], 1505 'mac_asan': ['compile'],
1502 #TODO(stip): Change the name of this builder to reflect that it's release. 1506 #TODO(stip): Change the name of this builder to reflect that it's release.
1503 'linux_gtk': standard_tests, 1507 'linux_gtk': standard_tests,
1504 'linux_chromeos_asan': ['compile'], 1508 'linux_chromeos_asan': ['compile'],
1505 'linux_chromium_chromeos_clang_dbg': ['defaulttests'], 1509 'linux_chromium_chromeos_clang_dbg': ['defaulttests'],
1506 'linux_chromium_chromeos_rel_swarming': ['defaulttests'], 1510 'linux_chromium_chromeos_rel_swarming': ['defaulttests'],
1507 'linux_chromium_compile_dbg': ['defaulttests'], 1511 'linux_chromium_compile_dbg': ['defaulttests'],
1512 'linux_chromium_gn_dbg': ['compile'],
1508 'linux_chromium_gn_rel': ['defaulttests'], 1513 'linux_chromium_gn_rel': ['defaulttests'],
1509 'linux_chromium_rel_swarming': ['defaulttests'], 1514 'linux_chromium_rel_swarming': ['defaulttests'],
1510 'linux_chromium_clang_dbg': ['defaulttests'], 1515 'linux_chromium_clang_dbg': ['defaulttests'],
1511 'linux_gpu': ['defaulttests'], 1516 'linux_gpu': ['defaulttests'],
1512 'linux_nacl_sdk_build': ['compile'], 1517 'linux_nacl_sdk_build': ['compile'],
1513 'mac_chromium_compile_dbg': ['defaulttests'], 1518 'mac_chromium_compile_dbg': ['defaulttests'],
1514 'mac_chromium_rel_swarming': ['defaulttests'], 1519 'mac_chromium_rel_swarming': ['defaulttests'],
1515 'mac_gpu': ['defaulttests'], 1520 'mac_gpu': ['defaulttests'],
1516 'mac_nacl_sdk_build': ['compile'], 1521 'mac_nacl_sdk_build': ['compile'],
1517 'win_chromium_compile_dbg': ['defaulttests'], 1522 'win_chromium_compile_dbg': ['defaulttests'],
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
1577 if all(re.search(r'(^|[\\\/_])android[\\\/_.]', f) for f in files): 1582 if all(re.search(r'(^|[\\\/_])android[\\\/_.]', f) for f in files):
1578 return GetDefaultTryConfigs([ 1583 return GetDefaultTryConfigs([
1579 'android_aosp', 1584 'android_aosp',
1580 'android_clang_dbg', 1585 'android_clang_dbg',
1581 'android_dbg_tests_recipe', 1586 'android_dbg_tests_recipe',
1582 ]) 1587 ])
1583 if all(re.search(r'[\\\/_]ios[\\\/_.]', f) for f in files): 1588 if all(re.search(r'[\\\/_]ios[\\\/_.]', f) for f in files):
1584 return GetDefaultTryConfigs(['ios_rel_device', 'ios_dbg_simulator']) 1589 return GetDefaultTryConfigs(['ios_rel_device', 'ios_dbg_simulator'])
1585 1590
1586 builders = [ 1591 builders = [
1592 'android_arm64_dbg_recipe',
1587 'android_chromium_gn_compile_rel', 1593 'android_chromium_gn_compile_rel',
1594 'android_chromium_gn_compile_dbg',
1588 'android_clang_dbg', 1595 'android_clang_dbg',
1596 'android_clang_dbg_recipe',
1589 'android_dbg_tests_recipe', 1597 'android_dbg_tests_recipe',
1590 'ios_dbg_simulator', 1598 'ios_dbg_simulator',
1591 'ios_rel_device', 1599 'ios_rel_device',
1600 'ios_rel_device_ninja',
1592 'linux_chromium_chromeos_rel_swarming', 1601 'linux_chromium_chromeos_rel_swarming',
1593 'linux_chromium_clang_dbg', 1602 'linux_chromium_clang_dbg',
1603 'linux_chromium_gn_dbg',
1594 'linux_chromium_gn_rel', 1604 'linux_chromium_gn_rel',
1595 'linux_chromium_rel_swarming', 1605 'linux_chromium_rel_swarming',
1596 'linux_gpu', 1606 'linux_gpu',
1597 'mac_chromium_compile_dbg', 1607 'mac_chromium_compile_dbg',
1598 'mac_chromium_rel_swarming', 1608 'mac_chromium_rel_swarming',
1599 'mac_gpu', 1609 'mac_gpu',
1600 'win_chromium_compile_dbg', 1610 'win_chromium_compile_dbg',
1601 'win_chromium_rel_swarming', 1611 'win_chromium_rel_swarming',
1602 'win_chromium_x64_rel_swarming', 1612 'win_chromium_x64_rel_swarming',
1603 'win_gpu', 1613 'win_gpu',
(...skipping 17 matching lines...) Expand all
1621 builders.extend(['cros_x86']) 1631 builders.extend(['cros_x86'])
1622 1632
1623 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it 1633 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it
1624 # unless they're .gyp(i) files as changes to those files can break the gyp 1634 # unless they're .gyp(i) files as changes to those files can break the gyp
1625 # step on that bot. 1635 # step on that bot.
1626 if (not all(re.search('^chrome', f) for f in files) or 1636 if (not all(re.search('^chrome', f) for f in files) or
1627 any(re.search('\.gypi?$', f) for f in files)): 1637 any(re.search('\.gypi?$', f) for f in files)):
1628 builders.extend(['android_aosp']) 1638 builders.extend(['android_aosp'])
1629 1639
1630 return GetDefaultTryConfigs(builders) 1640 return GetDefaultTryConfigs(builders)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698